Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Become: false for operation /tmp/opensearch-nodecerts #48

Closed
wants to merge 2 commits into from
Closed

Conversation

patsevanton
Copy link
Contributor

@patsevanton patsevanton commented Apr 6, 2022

Signed-off-by: Anton Patsev patsev.anton@gmail.com

Description

Become: false for operation /tmp/opensearch-nodecerts

Issues Resolved

Fix #45

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Anton Patsev <patsev.anton@gmail.com>
@peterzhuamazon
Copy link
Member

@saravanan30erd
Copy link
Collaborator

I am more thinking about whether this is a change that is suitable for the playbook tho.
If this is only a change for non-root user, a comment in README on what to change probably enough.
Will this change cause any issues with root user?

@peterzhuamazon this change will be useful for few scenarios. Example, when we create ec2 machines and it comes with default user ec2-user with sudo privileges. To run the playbook as root user, we need to prepare the root user in these machines like adding ssh keys. But if we use default user ec2-user, then we don't need to do these ssh key changes and this effort can be avoided.

But this change shouldn't cause any issues when we run with root user as well.

@saravanan30erd
Copy link
Collaborator

@patsevanton There are six tasks (which using local_action) runs in local machine which mean all those tasks required become: false but you put become: false only for 3 tasks, which mean other 3 tasks might fail when we use --become. Could you please check it or provide the reason?

@patsevanton
Copy link
Contributor Author

patsevanton commented Apr 7, 2022

Add become: false for 6 local_action in security.yml
I forgot Signed-off

@peterzhuamazon
Copy link
Member

Hi @patsevanton if you can sign off and @saravanan30erd can review that would be great.

@patsevanton
Copy link
Contributor Author

New PR #51

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][opensearch] sudo: a password is required
3 participants