Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SearchPipelines] Lower compatibility version to 2.7 #7135

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

msfroh
Copy link
Collaborator

@msfroh msfroh commented Apr 13, 2023

Description

The search pipelines code should be available starting in OpenSearch 2.7, so compatibility checks should start from that version.

Note that the Gradle checks for this PR may fail until #7075 is merged.

Issues Resolved

Follow-on from #7075, which is a backport of #6587, which resolves opensearch-project/search-processor#97.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

The search pipelines code should be available starting in OpenSearch
2.7, so compatibility checks should start from that version.

Signed-off-by: Michael Froh <froh@amazon.com>
@msfroh msfroh force-pushed the compatibility_version_2_7 branch from 4974548 to 3a4b3fb Compare April 13, 2023 01:19
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Apr 13, 2023

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/13973/

* **CommitID:** [3a4b3fb](https://github.com/opensearch-project/OpenSearch/commit/3a4b3fbe7214158d51c03f149ec6d86af2d7a88f)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

@msfroh the BWC test failures are OK at this moment, once the pull request to 2.x gets in, the tests will be green, thank you.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit 3cb2565 into opensearch-project:main Apr 13, 2023
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Apr 28, 2023
…ect#7135)

The search pipelines code should be available starting in OpenSearch
2.7, so compatibility checks should start from that version.

Signed-off-by: Michael Froh <froh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prototype search pipelines
3 participants