fail fast LeaderCheck on CoordinationStateRejectedException #17400
Conversation
anuragrai16
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
anuragrai16
force-pushed
the
fail-fast-leader-check
branch
from
cb70223 to
c60fc77
Compare
|
❌ Gradle check result for c60fc77: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anurag Rai <anurag.rai@uber.com>
Signed-off-by: Anurag Rai <anurag.rai@uber.com>
anuragrai16
force-pushed
the
fail-fast-leader-check
branch
from
72452c7 to
9292aa3
Compare
|
❌ Gradle check result for 9292aa3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 9292aa3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
| } else if (exp.getCause() instanceof CoordinationStateRejectedException) { | ||
| logger.debug(new ParameterizedMessage("leader [{}] rejected coordination state", leader), exp); | ||
| leaderFailed(new CoordinationStateRejectedException("node [" + leader + "] rejected coordination state", exp)); | ||
| return; |
There was a problem hiding this comment.
It's quite possible this check might succeed on the next liveness check interval, failing fast might turn out to be disruptive?
Description
This PR adds a provision to fail-fast the leaderCheck quickly if a
CoordinationStateRejectedExceptionexception is received. Please see the related issue for more details.Related Issues
Resolves #17155
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.