Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump net.minidev:json-smart from 2.5.1 to 2.5.2 in /plugins/repository-hdfs #17376

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 17, 2025

Bumps net.minidev:json-smart from 2.5.1 to 2.5.2.

Release notes

Sourced from net.minidev:json-smart's releases.

2.5.2

About CVE-2024-57699

Thanks for @​ccudennec-otto Some remarks on the CVE, more discussions in #236

  • as mentioned here it is quite unlikely that the vulnerability is exploited if you come here because of Spring Security / com.nimbusds:oauth2-oidc-sdk
  • the code changes for the upcoming release will "only" fix the default modes provided by JSONParser, e.g. MODE_RFC4627
  • if you create the JSONParser manually / with custom options, make sure you set option LIMIT_JSON_DEPTH
    • since that's what "connect2id" is doing in their library, they were responsible for fixing it. They've already provided a new 11.x release that fixes the JSONParser setup on their side, i.e. you rather need their fixed version and not version 2.5.2 of json-smart
    • as stated here, they would also need to backport the fix to the versions that Spring Security needs IMHO

What's Changed

... (truncated)

Commits
  • d4f7fa4 migrate to s01.oss.sonatype.org
  • 9ca093d docs: mark v2.5.2 not released now
  • 55fa105 update maintainer github id and email (#234)
  • 7ecb1d3 bump to version 2.5.2.
  • 852caf6 Merge pull request #233 from ccudennec-otto/fix-CVE-2024-57699
  • d1f4645 Merge pull request #228 from netplex/dependabot/maven/json-smart/junit.versio...
  • 19a787e Merge pull request #230 from netplex/dependabot/maven/json-smart-action/junit...
  • f2be4c1 Merge pull request #229 from netplex/dependabot/maven/json-smart/org.apache.m...
  • 224943a Merge pull request #231 from netplex/dependabot/maven/json-smart-action/org.a...
  • c21d854 fix CVE-2024-57699 for predefined parsers
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Copy link
Contributor

❌ Gradle check result for 66c937a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@cwperks
Copy link
Member

cwperks commented Feb 20, 2025

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/gradle/plugins/repository-hdfs/net.minidev-json-smart-2.5.2 branch from 66c937a to 7a27851 Compare February 20, 2025 03:08
Copy link
Contributor

❌ Gradle check result for 22abb07: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@cwperks
Copy link
Member

cwperks commented Feb 20, 2025

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/gradle/plugins/repository-hdfs/net.minidev-json-smart-2.5.2 branch from 22abb07 to 9ce025f Compare February 20, 2025 16:05
Copy link
Contributor

❌ Gradle check result for 7ccbcd1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@cwperks
Copy link
Member

cwperks commented Feb 20, 2025

@dependabot rebase

Bumps [net.minidev:json-smart](https://github.com/netplex/json-smart-v2) from 2.5.1 to 2.5.2.
- [Release notes](https://github.com/netplex/json-smart-v2/releases)
- [Commits](netplex/json-smart-v2@2.5.1...2.5.2)

---
updated-dependencies:
- dependency-name: net.minidev:json-smart
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/plugins/repository-hdfs/net.minidev-json-smart-2.5.2 branch from 7ccbcd1 to 3b57765 Compare February 20, 2025 18:36
Signed-off-by: dependabot[bot] <support@github.com>
@jainankitk
Copy link
Collaborator

@cwperks - Wondering if this change needs a changelog entry?

@cwperks
Copy link
Member

cwperks commented Feb 20, 2025

@cwperks - Wondering if this change needs a changelog entry?

After the CI is finished running, there's another workflow for dependabot PRs to do actions like add to the CHANGELOG and updateSHAs.

Copy link
Contributor

❌ Gradle check result for be40049: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for be40049: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.44%. Comparing base (bad652b) to head (be40049).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #17376   +/-   ##
=========================================
  Coverage     72.43%   72.44%           
+ Complexity    65591    65585    -6     
=========================================
  Files          5291     5291           
  Lines        304325   304325           
  Branches      44181    44181           
=========================================
+ Hits         220445   220473   +28     
+ Misses        65813    65754   -59     
- Partials      18067    18098   +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwperks
Copy link
Member

cwperks commented Feb 21, 2025

Looks like the CHANGELOG was skipped because it was done in #17378 for the same dep in a different module.

These modules have not been switched over to use the gradle version catalog yet which will help reduce such cases from 2 separate PRs to a single dependabot PR.

@cwperks cwperks added skip-changelog backport 2.x Backport to 2.x branch labels Feb 21, 2025
@cwperks cwperks merged commit 664f254 into main Feb 21, 2025
37 of 38 checks passed
@dependabot dependabot bot deleted the dependabot/gradle/plugins/repository-hdfs/net.minidev-json-smart-2.5.2 branch February 21, 2025 13:01
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 21, 2025
…y-hdfs (#17376)

* Bump net.minidev:json-smart in /plugins/repository-hdfs

Bumps [net.minidev:json-smart](https://github.com/netplex/json-smart-v2) from 2.5.1 to 2.5.2.
- [Release notes](https://github.com/netplex/json-smart-v2/releases)
- [Commits](netplex/json-smart-v2@2.5.1...2.5.2)

---
updated-dependencies:
- dependency-name: net.minidev:json-smart
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Updating SHAs

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 664f254)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch dependabot PRs with auto version bumps from dependabot dependencies Pull requests that update a dependency file skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants