Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove master term from AckedRequest #17249

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

andrross
Copy link
Member

@andrross andrross commented Feb 4, 2025

Related Issues

Related to #5214

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Copy link
Contributor

github-actions bot commented Feb 4, 2025

✅ Gradle check result for 55883b7: SUCCESS

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.37%. Comparing base (b82ed5a) to head (55883b7).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...s/upgrade/post/TransportUpgradeSettingsAction.java 0.00% 1 Missing ⚠️
...ster/metadata/MetadataCreateDataStreamService.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17249      +/-   ##
============================================
+ Coverage     72.29%   72.37%   +0.07%     
- Complexity    65699    65721      +22     
============================================
  Files          5318     5317       -1     
  Lines        305676   305674       -2     
  Branches      44350    44350              
============================================
+ Hits         220992   221230     +238     
+ Misses        66582    66312     -270     
- Partials      18102    18132      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit 99df856 into opensearch-project:main Feb 5, 2025
56 checks passed
@andrross andrross deleted the master-acked-request branch February 5, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants