-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pull-based Ingestion] use ConfigurationUtil for KafkaSourceConfig #17223
Conversation
Signed-off-by: Yupeng Fu <yupeng@uber.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17223 +/- ##
============================================
+ Coverage 72.24% 72.33% +0.09%
- Complexity 65704 65756 +52
============================================
Files 5318 5319 +1
Lines 305674 305735 +61
Branches 44349 44360 +11
============================================
+ Hits 220834 221163 +329
+ Misses 66769 66460 -309
- Partials 18071 18112 +41 ☔ View full report in Codecov by Sentry. |
❌ Gradle check result for 9751caf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
Inspired by the ConfigurationUtil in the ingest package, introduce a ConfigurationUtil to the common util (and later can consolidate with the one in ingest package).
used this configurationUtil for configuration parsing in KafkaSourceConfig
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.