Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Retrieve value from DocValues in a flat_object filed #17106

Merged

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Jan 24, 2025

Description

Backport cf49717 from #16802

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: kkewwei <kewei.11@bytedance.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Copy link
Contributor

✅ Gradle check result for 6dfbd0f: SUCCESS

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.96%. Comparing base (421f211) to head (6dfbd0f).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...opensearch/index/mapper/FlatObjectFieldMapper.java 54.54% 7 Missing and 3 partials ⚠️
...a/org/opensearch/index/mapper/DocValueFetcher.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #17106      +/-   ##
============================================
+ Coverage     71.90%   71.96%   +0.05%     
- Complexity    65701    65729      +28     
============================================
  Files          5322     5322              
  Lines        306191   306214      +23     
  Branches      44650    44655       +5     
============================================
+ Hits         220177   220363     +186     
+ Misses        67668    67473     -195     
- Partials      18346    18378      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh msfroh merged commit fa08247 into opensearch-project:2.x Jan 24, 2025
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants