Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove withLongNumerals in HttpFetchOptions as it is deprecated in 3.0 #9448

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

angle943
Copy link
Collaborator

Description

#5592 renamed withLongNumerals to withLongNumeralsSupport in HttpFetchOptions. Now we are removing the deprecated withLongNumerals for 3.0

Issues Resolved

Part of #9253

Changelog

  • breaking: remove withLongNumerals in HttpFetchOptions.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Justin Kim <jungkm@amazon.com>
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.74%. Comparing base (796e481) to head (fb47f6c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9448   +/-   ##
=======================================
  Coverage   61.74%   61.74%           
=======================================
  Files        3816     3816           
  Lines       91890    91888    -2     
  Branches    14564    14564           
=======================================
  Hits        56738    56738           
+ Misses      31494    31493    -1     
+ Partials     3658     3657    -1     
Flag Coverage Δ
Linux_1 28.98% <0.00%> (+<0.01%) ⬆️
Linux_2 56.41% <100.00%> (-0.01%) ⬇️
Linux_3 39.27% <0.00%> (+<0.01%) ⬆️
Linux_4 28.87% <0.00%> (+<0.01%) ⬆️
Windows_1 29.00% <0.00%> (+<0.01%) ⬆️
Windows_2 56.36% <100.00%> (-0.01%) ⬇️
Windows_3 39.27% <0.00%> (+<0.01%) ⬆️
Windows_4 28.87% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angle943 angle943 merged commit 06748d2 into opensearch-project:main Feb 27, 2025
72 checks passed
@angle943 angle943 deleted the remove-with-long-numerals branch February 27, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants