Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated CssDistFilename for 3.0 #9446

Merged

Conversation

angle943
Copy link
Collaborator

Description

#7625 has deprecated various CssDistFilename from osd-ui-shared-deps. For 3.0 release, we are removing them from the codebase.

Issues Resolved

Part of #9253.

Changelog

  • breaking: remove CssDistFilename

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Justin Kim <jungkm@amazon.com>
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.73%. Comparing base (946c6bb) to head (314288e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9446      +/-   ##
==========================================
- Coverage   61.74%   61.73%   -0.01%     
==========================================
  Files        3816     3816              
  Lines       91890    91886       -4     
  Branches    14563    14563              
==========================================
- Hits        56733    56729       -4     
  Misses      31497    31497              
  Partials     3660     3660              
Flag Coverage Δ
Linux_1 28.98% <ø> (-0.01%) ⬇️
Linux_2 56.41% <ø> (-0.01%) ⬇️
Linux_3 39.25% <ø> (-0.01%) ⬇️
Linux_4 28.86% <ø> (-0.01%) ⬇️
Windows_1 29.00% <ø> (-0.01%) ⬇️
Windows_2 56.36% <ø> (-0.01%) ⬇️
Windows_3 39.25% <ø> (-0.01%) ⬇️
Windows_4 28.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwin-pc ashwin-pc merged commit 071213b into opensearch-project:main Feb 26, 2025
77 checks passed
@angle943 angle943 deleted the remove-deprecated-CssDistFilename branch February 26, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants