Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump markdown-it from 12.3.2 to 13.0.2 #9412

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Feb 18, 2025

Description

Bump markdown-it from 12.3.2 to 13.0.2

yarn why markdown-it
yarn why v1.22.21
[1/4] 🤔  Why do we have the module "markdown-it"...?
[2/4] 🚚  Initialising dependency graph...
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@~4.5.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Lockfile has incorrect entry for "typescript@4.0.2". Ignoring it.
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
warning Resolution field "typescript@4.6.4" is incompatible with requested version "typescript@4.0.2"
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "markdown-it@13.0.2"
info Has been hoisted to "markdown-it"
info Reasons this module exists
   - "workspace-aggregator-b3b81190-140d-44fa-9437-3a525a0e2d1e" depends on it
   - Specified in "devDependencies"
   - Hoisted from "_project_#@osd#dev-utils#markdown-it"
   - Hoisted from "_project_#markdown-it"
info Disk size without dependencies: "1MB"
info Disk size with unique dependencies: "1.57MB"
info Disk size with transitive dependencies: "1.64MB"
info Number of shared dependencies: 6
✨  Done in 1.66s.

Changelog

  • security: Bump markdown-it from 12.3.2 to 13.0.2

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Anan <ananzh@amazon.com>
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.72%. Comparing base (c220796) to head (90d9b2e).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9412   +/-   ##
=======================================
  Coverage   61.71%   61.72%           
=======================================
  Files        3817     3817           
  Lines       91860    91860           
  Branches    14551    14551           
=======================================
+ Hits        56695    56697    +2     
+ Misses      31508    31507    -1     
+ Partials     3657     3656    -1     
Flag Coverage Δ
Linux_1 29.00% <ø> (ø)
Linux_2 56.46% <ø> (ø)
Linux_3 39.20% <ø> (?)
Linux_4 28.90% <ø> (ø)
Windows_1 29.01% <ø> (ø)
Windows_2 56.41% <ø> (ø)
Windows_3 39.20% <ø> (ø)
Windows_4 28.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sulabhjain-dev
Copy link

Thanks @ananzh for the PR. Looks good.

@ananzh ananzh added backport 2.19 v2.19.1 Issues targeting release v2.19.1 and removed v2.20.0 labels Feb 26, 2025
@ananzh ananzh merged commit 3486976 into opensearch-project:main Feb 26, 2025
80 of 81 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-9412-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3486976d3472fa80c63698ce478cb35917ad1872
# Push it to GitHub
git push --set-upstream origin backport/backport-9412-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9412-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.19
# Create a new branch
git switch --create backport/backport-9412-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3486976d3472fa80c63698ce478cb35917ad1872
# Push it to GitHub
git push --set-upstream origin backport/backport-9412-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.19

Then, create a pull request where the base branch is 2.19 and the compare/head branch is backport/backport-9412-to-2.19.

ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Feb 26, 2025
* Bump markdown-it from 12.3.2 to 13.0.2

Signed-off-by: Anan <ananzh@amazon.com>

* Changeset file for PR opensearch-project#9412 created/updated

---------

Signed-off-by: Anan <ananzh@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Feb 26, 2025
…rch-project#9412)

* Bump markdown-it from 12.3.2 to 13.0.2

Backport PR: opensearch-project#9412

---------

Signed-off-by: Anan <ananzh@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ananzh added a commit that referenced this pull request Feb 26, 2025
…9452)

* Bump markdown-it from 12.3.2 to 13.0.2

Backport PR: #9412

---------

Signed-off-by: Anan <ananzh@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 26, 2025
…9452)

* Bump markdown-it from 12.3.2 to 13.0.2

Backport PR: #9412

---------

Signed-off-by: Anan <ananzh@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit e45d8d3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh pushed a commit that referenced this pull request Feb 26, 2025
…9452) (#9456)

* Bump markdown-it from 12.3.2 to 13.0.2

Backport PR: #9412

---------



(cherry picked from commit e45d8d3)

Signed-off-by: Anan <ananzh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.19 cve Security vulnerabilities detected by Dependabot or Mend distinguished-contributor failed backport v2.19.1 Issues targeting release v2.19.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants