Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow-up #9386] Add TODO and omit for hide missing values for SQL and PPL #9402

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Feb 17, 2025

Description

Follow-up #9386 comment: #9386 (comment)

Issues Resolved

Follow-up PR:
#9386

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…g values for SQL and PPL

Follow-up PR:
opensearch-project#9386

Signed-off-by: Anan <ananzh@amazon.com>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@github-actions github-actions bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.71%. Comparing base (c220796) to head (52514b6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9402   +/-   ##
=======================================
  Coverage   61.71%   61.71%           
=======================================
  Files        3817     3817           
  Lines       91860    91860           
  Branches    14551    14551           
=======================================
  Hits        56695    56695           
  Misses      31508    31508           
  Partials     3657     3657           
Flag Coverage Δ
Linux_1 29.00% <ø> (ø)
Linux_2 56.46% <ø> (ø)
Linux_3 39.20% <ø> (?)
Linux_4 28.90% <ø> (ø)
Windows_1 29.01% <ø> (ø)
Windows_2 56.41% <ø> (ø)
Windows_3 39.20% <ø> (ø)
Windows_4 28.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh ananzh merged commit 2b6e7bf into opensearch-project:main Feb 17, 2025
80 of 82 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-9402-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2b6e7bfd5a11f21fc0ad883f40022abf8989bf3a
# Push it to GitHub
git push --set-upstream origin backport/backport-9402-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9402-to-2.x.

sumukhswamy pushed a commit to sumukhswamy/OpenSearch-Dashboards that referenced this pull request Feb 18, 2025
…g values for SQL and PPL (opensearch-project#9402)

Follow-up PR:
opensearch-project#9386

Signed-off-by: Anan <ananzh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative failed backport Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.20.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants