-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Follow-up #9386] Add TODO and omit for hide missing values for SQL and PPL #9402
Conversation
…g values for SQL and PPL Follow-up PR: opensearch-project#9386 Signed-off-by: Anan <ananzh@amazon.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9402 +/- ##
=======================================
Coverage 61.71% 61.71%
=======================================
Files 3817 3817
Lines 91860 91860
Branches 14551 14551
=======================================
Hits 56695 56695
Misses 31508 31508
Partials 3657 3657
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-9402-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2b6e7bfd5a11f21fc0ad883f40022abf8989bf3a
# Push it to GitHub
git push --set-upstream origin backport/backport-9402-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…g values for SQL and PPL (opensearch-project#9402) Follow-up PR: opensearch-project#9386 Signed-off-by: Anan <ananzh@amazon.com>
Description
Follow-up #9386 comment: #9386 (comment)
Issues Resolved
Follow-up PR:
#9386
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration