Remove reload in saved_search spec as bug has been resolved #9396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Argus Li <contactme@chunkeili.com>
ArgusLi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9396 +/- ##
=======================================
Coverage 61.72% 61.72%
=======================================
Files 3817 3817
Lines 91860 91860
Branches 14551 14551
=======================================
Hits 56697 56697
Misses 31507 31507
Partials 3656 3656
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
angle943
approved these changes
Feb 15, 2025
ananzh
approved these changes
Feb 16, 2025
ananzh
added
discover_2.0-test
wanglam
approved these changes
Feb 17, 2025
SuZhou-Joe
approved these changes
Feb 17, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
* Remove reload as bug has been resolved. Signed-off-by: Argus Li <contactme@chunkeili.com> * Changeset file for PR #9396 created/updated --------- Signed-off-by: Argus Li <contactme@chunkeili.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 0f32a25) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sumukhswamy
pushed a commit
to sumukhswamy/OpenSearch-Dashboards
that referenced
this pull request
Feb 18, 2025
…ch-project#9396) * Remove reload as bug has been resolved. Signed-off-by: Argus Li <contactme@chunkeili.com> * Changeset file for PR opensearch-project#9396 created/updated --------- Signed-off-by: Argus Li <contactme@chunkeili.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To workaround a bug, a reload was added. Now that the bug has been resolved, the reload no longer needs to be there.
Issues Resolved
closes #9131
Screenshot
Testing the changes
With OSD running, run yarn run cypress open. In E2E specs, you will see saved_search.spec.js. Run the test spec.
Changelog