addressing comments

Signed-off-by: Sean Li <lnse@amazon.com>
opensearch-project · Feb 19, 2025 · 6b8e830 · 6b8e830
1 parent 3a695da
commit 6b8e830
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/...re_opensearch_dashboards/opensearch_dashboards/apps/query_enhancements/s3_dataset.spec.js b/...re_opensearch_dashboards/opensearch_dashboards/apps/query_enhancements/s3_dataset.spec.js
@@ -7,7 +7,7 @@ import {
   DS_API,
   DSM_API,
   S3_CLUSTER,
-  DELETE_API,
+  JOBS_API,
 } from '../../../../../utils/apps/query_enhancements/constants';
 import { getRandomizedWorkspaceName } from '../../../../../utils/apps/query_enhancements/shared';
 import { prepareTestSuite } from '../../../../../utils/helpers';
@@ -166,7 +166,7 @@ const s3DatasetTestSuite = () => {
           // Need to wait a bit for initial query to start
           cy.wait(3000);
 
-          cy.intercept('DELETE', `**/${DELETE_API}*`).as('cancelRequest');
+          cy.intercept('DELETE', `**/${JOBS_API.DELETE}*`).as('cancelRequest');
           cy.getElementByTestId(`querySubmitButton`).click();
 
           cy.wait('@cancelRequest').then((interception) => {

diff --git a/cypress/utils/apps/query_enhancements/constants.js b/cypress/utils/apps/query_enhancements/constants.js
@@ -21,7 +21,10 @@ export const DS_API = {
 };
 export const DSM_API = '/internal/data-source-management/fetchDataSourceMetaData';
 
-export const DELETE_API = '/api/enhancements/jobs';
+export const BASE_QUERY_ENHANCEMENTS_API = '/api/enhancements';
+export const JOBS_API = {
+  DELETE: `${BASE_QUERY_ENHANCEMENTS_API}/jobs`,
+};
 
 export const INDEX_WITH_TIME_1 = 'data_logs_small_time_1';
 export const INDEX_WITHOUT_TIME_1 = 'data_logs_small_no_time_1';

diff --git a/src/plugins/query_enhancements/server/routes/data_source_connection/routes.ts b/src/plugins/query_enhancements/server/routes/data_source_connection/routes.ts
@@ -102,7 +102,7 @@ export function registerDataSourceConnectionsRoutes(
 
   router.delete(
     {
-      path: `${API.DATA_SOURCE.ASYNC_JOBS}`,
+      path: API.DATA_SOURCE.ASYNC_JOBS,
       validate: {
         query: schema.object({
           id: schema.string(),