Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GitHub Request Template in .github repository #238

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Dec 2, 2024

Description

Adding GitHub Request Template in .github repository

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@gaiksaya
Copy link
Member

gaiksaya commented Dec 3, 2024

Maybe try using template like this https://raw.githubusercontent.com/opensearch-project/opensearch-build/refs/heads/main/.github/ISSUE_TEMPLATE/plugin_onboarding_template.yaml so that required fields are met before creating the request.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this @peterzhuamazon - I like the look of that project board too

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some nits.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looking really slick! Couple of minor comments

@getsaurabh02
Copy link
Member

Looks good to me, thanks Peter

@peterzhuamazon
Copy link
Member Author

Thanks All for the review here.

Are we ready to get it merged and start using it?
(cc: @anastead @Pallavi-AWS @dblock @getsaurabh02 @rishabh6788 @prudhvigodithi @gaiksaya @reta @tykeal)

Thanks.

@reta
Copy link

reta commented Dec 5, 2024

Are we ready to get it merged and start using it?

LGTM! Thanks @peterzhuamazon !

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix typos and spelling.

peternied
peternied previously approved these changes Dec 5, 2024
@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Dec 5, 2024

Thanks @peternied for the approval here, please approve again since I just pushed a new commit.

Hi @dblock, please take another pass as I just committed all the suggested changes.

Thanks!

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@dbwiddis
Copy link
Member

dbwiddis commented Dec 5, 2024

Do we really need a bake time of 48 hours for typo fixes?

@dblock
Copy link
Member

dblock commented Dec 6, 2024

Do we really need a bake time of 48 hours for typo fixes?

It's a good mechanism, we are not in a hurry!

@peterzhuamazon peterzhuamazon merged commit c527ccf into opensearch-project:main Dec 9, 2024
3 checks passed
@peterzhuamazon peterzhuamazon deleted the github-request-template branch December 9, 2024 17:48
@peterzhuamazon
Copy link
Member Author

Thanks everyone, I will broadcast this on multiple channels soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request github-request Roadmap:Releases/Project Health Project-wide roadmap label
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

7 participants