-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GitHub Request Template in .github repository #238
Adding GitHub Request Template in .github repository #238
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Maybe try using template like this https://raw.githubusercontent.com/opensearch-project/opensearch-build/refs/heads/main/.github/ISSUE_TEMPLATE/plugin_onboarding_template.yaml so that required fields are met before creating the request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this @peterzhuamazon - I like the look of that project board too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some nits.
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Hi @dblock @peternied @gaiksaya , Example template after I update the PR with suggestions. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, looking really slick! Couple of minor comments
Looks good to me, thanks Peter |
Thanks All for the review here. Are we ready to get it merged and start using it? Thanks. |
LGTM! Thanks @peterzhuamazon ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix typos and spelling.
Thanks @peternied for the approval here, please approve again since I just pushed a new commit. Hi @dblock, please take another pass as I just committed all the suggested changes. Thanks! |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Do we really need a bake time of 48 hours for typo fixes? |
It's a good mechanism, we are not in a hurry! |
Thanks everyone, I will broadcast this on multiple channels soon. |
Description
Adding GitHub Request Template in .github repository
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.