From 99b6537b50f26063c5f6602047e19b1ce1212373 Mon Sep 17 00:00:00 2001 From: Giulio Valentino Dalla Riva Date: Tue, 17 Dec 2024 10:52:15 +1300 Subject: [PATCH 1/4] parentCode fetching from parentNode if it exists Fixing a bug where the parent code ids where not reachable. --- R/SDMXCode-methods.R | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/R/SDMXCode-methods.R b/R/SDMXCode-methods.R index a0f25da..30ed9f8 100644 --- a/R/SDMXCode-methods.R +++ b/R/SDMXCode-methods.R @@ -39,8 +39,16 @@ SDMXCode <- function(xmlObj, namespaces){ urn = xmlGetAttr(xmlObj, "urn") if(is.null(urn)) urn <- as.character(NA) - parentCode = xmlGetAttr(xmlObj, "parentCode") - if(is.null(parentCode)) parentCode <- as.character(NA) + parentCode <- as.character(NA) + parentId <- xmlGetAttr(xmlObj, "parentCode") + if(!is.null(parentId)) parentCode <- parentId + parentNode <- getNodeSet(xmlDoc(xmlObj), "//ns:Parent//Ref", namespaces = strNs) + if(length(parentNode) == 1) parentCode <- xmlGetAttr(parentNode[[1]], "id") + if(length(parentNode) > 1) { + parentCode <- sapply(parentNode, function(x) { xmlGetAttr(x, "id") }) + # we collapse the vector of parent codes into a single string as required by the SDMXCode class + parentCode <- paste(parentCode, collapse = ",") + } #elements #======== From 583e6f5a39e6542fbb4b2b5b265b1b2c1e43eacf Mon Sep 17 00:00:00 2001 From: gvdr Date: Tue, 17 Dec 2024 14:15:56 +1100 Subject: [PATCH 2/4] Test for hierarchical codelists --- ...SDMXCodelists_Example_hierarchical_2.1.xml | 3067 +++++++++++++++++ tests/testthat/test_Codelists.R | 25 +- 2 files changed, 3088 insertions(+), 4 deletions(-) create mode 100644 inst/extdata/SDMXCodelists_Example_hierarchical_2.1.xml diff --git a/inst/extdata/SDMXCodelists_Example_hierarchical_2.1.xml b/inst/extdata/SDMXCodelists_Example_hierarchical_2.1.xml new file mode 100644 index 0000000..bfea630 --- /dev/null +++ b/inst/extdata/SDMXCodelists_Example_hierarchical_2.1.xml @@ -0,0 +1,3067 @@ + + + + + IDREF3313 + false + 2024-12-17T00:41:26.1595+00:00 + + + + + + + Common hierarchical codelist for PICTs + Liste hiérarchique de codes commune pour les PICTs + + + + ORDER + 10000 + 10000 + + + Pacific region + Région du Pacifique + + + + + ORDER + 20000 + 20000 + + + Melanesia + Mélanésie + + + + + ORDER + 30000 + 30000 + + + Micronesia + Micronésie + + + + + ORDER + 40000 + 40000 + + + Polynesia + Polynésie + + + + + ORDER + 100 + 1700 + + + American Samoa + Samoa américaines + + + + + + + + ORDER + 101 + 1701 + + + Eastern + Eastern + + + + + + + + ORDER + 102 + 1702 + + + Manu'a + Manu'a + + + + + + + + ORDER + 103 + 1703 + + + Unorganized + Unorganized + + + + + + + + ORDER + 104 + 1704 + + + Western + Western + + + + + + + + ORDER + 200 + 400 + + + Cook Islands + Îles Cook + + + + + + + + ORDER + 201 + 401 + + + Northern Group + Groupe du Nord + + + + + + + + ORDER + 202 + 402 + + + Rarotonga + Rarotonga + + + + + + + + ORDER + 203 + 403 + + + Southern Group + Groupe du Sud + + + + + + + + ORDER + 300 + 200 + + + Fiji + Fidji + + + + + + + + ORDER + 301 + 201 + + + Central + Centre + + + + + + + + ORDER + 302 + 202 + + + Eastern + Est + + + + + + + + ORDER + 303 + 203 + + + Northern + Nord + + + + + + + + ORDER + 304 + 204 + + + Western + Ouest + + + + + + + + ORDER + 800 + 100 + + + Micronesia (Federated States of) + États fédérés de Micronésie (pays) + + + + + + + + ORDER + 801 + 101 + + + Chuuk + Chuuk + + + + + + + + ORDER + 802 + 102 + + + Kosrae + Kosrae + + + + + + + + ORDER + 803 + 103 + + + Pohnpei + Pohnpei + + + + + + + + ORDER + 804 + 104 + + + Yap + Yap + + + + + + + + ORDER + 500 + 300 + + + Guam + Guam + + + + + + + + ORDER + 501 + 301 + + + Agana Heights + Agana Heights + + + + + + + + ORDER + 502 + 302 + + + Agat + Agat + + + + + + + + ORDER + 503 + 303 + + + Asan + Asan + + + + + + + + ORDER + 504 + 304 + + + Barrigada + Barrigada + + + + + + + + ORDER + 505 + 305 + + + Chalan-Pago-Ordot + Chalan-Pago-Ordot + + + + + + + + ORDER + 506 + 306 + + + Dededo + Dededo + + + + + + + + ORDER + 507 + 307 + + + Hagåtña + Hagåtña + + + + + + + + ORDER + 508 + 308 + + + Inarajan + Inarajan + + + + + + + + ORDER + 509 + 309 + + + Mangilao + Mangilao + + + + + + + + ORDER + 510 + 310 + + + Merizo + Merizo + + + + + + + + ORDER + 511 + 311 + + + Mongmong-Toto-Maite + Mongmong-Toto-Maite + + + + + + + + ORDER + 512 + 312 + + + Piti + Piti + + + + + + + + ORDER + 513 + 313 + + + Santa Rita + Santa Rita + + + + + + + + ORDER + 514 + 314 + + + Sinajana + Sinajana + + + + + + + + ORDER + 515 + 315 + + + Talofofo + Talofofo + + + + + + + + ORDER + 516 + 316 + + + Tamuning + Tamuning + + + + + + + + ORDER + 517 + 317 + + + Umatac + Umatac + + + + + + + + ORDER + 518 + 318 + + + Yigo + Yigo + + + + + + + + ORDER + 519 + 319 + + + Yona + Yona + + + + + + + + ORDER + 600 + 800 + + + Kiribati + Kiribati + + + + + + + + ORDER + 601 + 801 + + + Banaba + Banaba + + + + + + + + ORDER + 602 + 802 + + + Makin + Makin + + + + + + + + ORDER + 603 + 803 + + + Butaritari + Butaritari + + + + + + + + ORDER + 604 + 804 + + + Marakei + Marakei + + + + + + + + ORDER + 605 + 805 + + + Abaiang + Abaiang + + + + + + + + ORDER + 606 + 806 + + + Nth.Tarawa + Nth.Tarawa + + + + + + + + ORDER + 607 + 807 + + + Sth.Tarawa + Sth.Tarawa + + + + + + + + ORDER + 608 + 808 + + + Maiana + Maiana + + + + + + + + ORDER + 609 + 809 + + + Abemama + Abemama + + + + + + + + ORDER + 610 + 810 + + + Kuria + Kuria + + + + + + + + ORDER + 611 + 811 + + + Aranuka + Aranuka + + + + + + + + ORDER + 612 + 812 + + + Nonouti + Nonouti + + + + + + + + ORDER + 613 + 813 + + + Tabiteuea.Nth + Tabiteuea.Nth + + + + + + + + ORDER + 614 + 814 + + + Tabiteuea.Sth + Tabiteuea.Sth + + + + + + + + ORDER + 615 + 815 + + + Beru + Beru + + + + + + + + ORDER + 616 + 816 + + + Nikunau + Nikunau + + + + + + + + ORDER + 617 + 817 + + + Onotoa + Onotoa + + + + + + + + ORDER + 618 + 818 + + + Tamana + Tamana + + + + + + + + ORDER + 619 + 819 + + + Arorae + Arorae + + + + + + + + ORDER + 620 + 820 + + + Teeraina + Teeraina + + + + + + + + ORDER + 621 + 821 + + + Tabuaeran + Tabuaeran + + + + + + + + ORDER + 622 + 822 + + + Kiritimati + Kiritimati + + + + + + + + ORDER + 623 + 823 + + + Kanton + Kanton + + + + + + + + ORDER + 700 + 600 + + + Marshall Islands + Îles Marshall (pays) + + + + + + + + ORDER + 701 + 601 + + + Ailinglaplap + Ailinglaplap + + + + + + + + ORDER + 702 + 602 + + + Ailuk + Ailuk + + + + + + + + ORDER + 703 + 603 + + + Arno + Arno + + + + + + + + ORDER + 704 + 604 + + + Aur + Aur + + + + + + + + ORDER + 705 + 605 + + + Eneu + Eneu + + + + + + + + ORDER + 706 + 606 + + + Ebon + Ebon + + + + + + + + ORDER + 707 + 607 + + + Enewetak + Enewetak + + + + + + + + ORDER + 708 + 608 + + + Jabat + Jabat + + + + + + + + ORDER + 709 + 609 + + + Jaluit + Jaluit + + + + + + + + ORDER + 710 + 610 + + + Kili + Kili + + + + + + + + ORDER + 711 + 611 + + + Kwajalein + Kwajalein + + + + + + + + ORDER + 712 + 612 + + + Lae + Lae + + + + + + + + ORDER + 713 + 613 + + + Lib + Lib + + + + + + + + ORDER + 714 + 614 + + + Likiep + Likiep + + + + + + + + ORDER + 715 + 615 + + + Majuro + Majuro + + + + + + + + ORDER + 716 + 616 + + + Maloelap + Maloelap + + + + + + + + ORDER + 717 + 617 + + + Mejit + Mejit + + + + + + + + ORDER + 718 + 618 + + + Mili + Mili + + + + + + + + ORDER + 719 + 619 + + + Namdrik + Namdrik + + + + + + + + ORDER + 720 + 620 + + + Namu + Namu + + + + + + + + ORDER + 721 + 621 + + + Rongelap + Rongelap + + + + + + + + ORDER + 722 + 622 + + + Ujae + Ujae + + + + + + + + ORDER + 723 + 623 + + + Utirik + Utirik + + + + + + + + ORDER + 724 + 624 + + + Wotho + Wotho + + + + + + + + ORDER + 725 + 625 + + + Wotje + Wotje + + + + + + + + ORDER + 1200 + 500 + + + Northern Mariana Islands + Îles Mariannes du Nord + + + + + + + + ORDER + 1201 + 501 + + + Saipan + Saipan + + + + + + + + ORDER + 1202 + 502 + + + Tinian + Tinian + + + + + + + + ORDER + 1203 + 503 + + + Rota + Rota + + + + + + + + ORDER + 1000 + 1100 + + + New Caledonia + Nouvelle-Calédonie + + + + + + + + ORDER + 1001 + 1101 + + + Loyalty Islands + Îles Loyauté + + + + + + + + ORDER + 1002 + 1102 + + + Northern Province + Province Nord + + + + + + + + ORDER + 1003 + 1103 + + + Southern Province + Province Sud + + + + + + + + ORDER + 900 + 900 + + + Nauru + Nauru + + + + + + + + ORDER + 901 + 901 + + + Yaren + Yaren + + + + + + + + ORDER + 902 + 902 + + + Boe + Boe + + + + + + + + ORDER + 903 + 903 + + + Aiwo + Aiwo + + + + + + + + ORDER + 904 + 904 + + + Buada + Buada + + + + + + + + ORDER + 905 + 905 + + + Denigomodu + Denigomodu + + + + + + + + ORDER + 906 + 906 + + + Nibok + Nibok + + + + + + + + ORDER + 907 + 907 + + + Uaeboe + Uaeboe + + + + + + + + ORDER + 908 + 908 + + + Baitsi + Baitsi + + + + + + + + ORDER + 909 + 909 + + + Ewa + Ewa + + + + + + + + ORDER + 910 + 910 + + + Anibare + Anibare + + + + + + + + ORDER + 911 + 911 + + + Anetan + Anetan + + + + + + + + ORDER + 912 + 912 + + + Anabar + Anabar + + + + + + + + ORDER + 913 + 913 + + + Ijuw + Ijuw + + + + + + + + ORDER + 914 + 914 + + + Meneng + Meneng + + + + + + + + ORDER + 915 + 915 + + + Location + Location + + + + + + + + ORDER + 1100 + 1000 + + + Niue + Niue + + + + + + + + ORDER + 1101 + 1001 + + + Alofi South + Alofi South + + + + + + + + ORDER + 1102 + 1002 + + + Alofi North + Alofi North + + + + + + + + ORDER + 1103 + 1003 + + + Makefu + Makefu + + + + + + + + ORDER + 1104 + 1004 + + + Tuapa + Tuapa + + + + + + + + ORDER + 1105 + 1005 + + + Namukulu + Namukulu + + + + + + + + ORDER + 1106 + 1006 + + + Hikutavake + Hikutavake + + + + + + + + ORDER + 1107 + 1007 + + + Toi + Toi + + + + + + + + ORDER + 1108 + 1008 + + + Mutalau + Mutalau + + + + + + + + ORDER + 1109 + 1009 + + + Lakepa + Lakepa + + + + + + + + ORDER + 1110 + 1010 + + + Liku + Liku + + + + + + + + ORDER + 1111 + 1011 + + + Hakupu + Hakupu + + + + + + + + ORDER + 1112 + 1012 + + + Vaiea + Vaiea + + + + + + + + ORDER + 1113 + 1013 + + + Avatele + Avatele + + + + + + + + ORDER + 1114 + 1014 + + + Tamakautoga + Tamakautoga + + + + + + + + ORDER + 400 + 1400 + + + French Polynesia + Polynésie française + + + + + + + + ORDER + 401 + 1401 + + + Îles Australes + Îles Australes + + + + + + + + ORDER + 402 + 1402 + + + Îles du Vent + Îles du Vent + + + + + + + + ORDER + 403 + 1403 + + + Îles Marquises + Îles Marquises + + + + + + + + ORDER + 404 + 1404 + + + Îles Sous-le-Vent + Îles Sous-le-Vent + + + + + + + + ORDER + 405 + 1405 + + + Îles Tuamotu-Gambier + Îles Tuamotu-Gambier + + + + + + + + ORDER + 1400 + 1300 + + + Papua New Guinea + Papouasie-Nouvelle-Guinée + + + + + + + + ORDER + 1401 + 1301 + + + Bougainville + Bougainville + + + + + + + + ORDER + 1402 + 1302 + + + Central + Central + + + + + + + + ORDER + 1403 + 1303 + + + Chimbu + Chimbu + + + + + + + + ORDER + 1404 + 1304 + + + East New Britain + East New Britain + + + + + + + + ORDER + 1405 + 1305 + + + East Sepik + East Sepik + + + + + + + + ORDER + 1406 + 1306 + + + Eastern Highlands + Eastern Highlands + + + + + + + + ORDER + 1407 + 1307 + + + Enga + Enga + + + + + + + + ORDER + 1408 + 1308 + + + Gulf + Gulf + + + + + + + + ORDER + 1409 + 1309 + + + Hela + Hela + + + + + + + + ORDER + 1410 + 1310 + + + Jiwaka + Jiwaka + + + + + + + + ORDER + 1411 + 1311 + + + Madang + Madang + + + + + + + + ORDER + 1412 + 1312 + + + Manus + Manus + + + + + + + + ORDER + 1413 + 1313 + + + Milne Bay + Milne Bay + + + + + + + + ORDER + 1414 + 1314 + + + Morobe + Morobe + + + + + + + + ORDER + 1415 + 1315 + + + National Capital District + National Capital District + + + + + + + + ORDER + 1416 + 1316 + + + New Ireland + New Ireland + + + + + + + + ORDER + 1417 + 1317 + + + Oro + Oro + + + + + + + + ORDER + 1418 + 1318 + + + Sandaun + Sandaun + + + + + + + + ORDER + 1419 + 1319 + + + Southern Highlands + Southern Highlands + + + + + + + + ORDER + 1420 + 1320 + + + West New Britain + West New Britain + + + + + + + + ORDER + 1421 + 1321 + + + Western + Western + + + + + + + + ORDER + 1422 + 1322 + + + Western Highlands + Western Highlands + + + + + + + + ORDER + 1500 + 700 + + + Pitcairn + Îles Pitcairn + + + + + + + + ORDER + 1300 + 1200 + + + Palau + Palaos + + + + + + + + ORDER + 1301 + 1201 + + + Koror + Koror + + + + + + + + ORDER + 1302 + 1202 + + + Airai + Airai + + + + + + + + ORDER + 1303 + 1203 + + + Outlying States + Outlying States + + + + + + + + ORDER + 1304 + 1204 + + + West Babeldaob + West Babeldaob + + + + + + + + ORDER + 1305 + 1205 + + + East Babeldaob + East Babeldaob + + + + + + + + ORDER + 1700 + 1500 + + + Solomon Islands + Salomon + + + + + + + + ORDER + 1701 + 1501 + + + Choiseul + Choiseul + + + + + + + + ORDER + 1702 + 1502 + + + Western + Western + + + + + + + + ORDER + 1703 + 1503 + + + Isabel + Isabel + + + + + + + + ORDER + 1704 + 1504 + + + Central + Central + + + + + + + + ORDER + 1705 + 1505 + + + Rennell-Bell + Rennell-Bell + + + + + + + + ORDER + 1706 + 1506 + + + Guadalcanal + Guadalcanal + + + + + + + + ORDER + 1707 + 1507 + + + Malaita + Malaita + + + + + + + + ORDER + 1708 + 1508 + + + Makira-Ulawa + Makira-Ulawa + + + + + + + + ORDER + 1709 + 1509 + + + Temotu + Temotu + + + + + + + + ORDER + 1710 + 1510 + + + Honiara + Honiara + + + + + + + + ORDER + 1800 + 1800 + + + Tokelau + Tokelau + + + + + + + + ORDER + 1801 + 1801 + + + Anafu + Anafu + + + + + + + + ORDER + 1802 + 1802 + + + Fakaofo + Fakaofo + + + + + + + + ORDER + 1803 + 1803 + + + Nukunonu + Nukunonu + + + + + + + + ORDER + 1900 + 1900 + + + Tonga + Tonga + + + + + + + + ORDER + 1901 + 1901 + + + Ha'apai + Ha'apai + + + + + + + + ORDER + 1902 + 1902 + + + 'Eua + 'Eua + + + + + + + + ORDER + 1903 + 1903 + + + Niuas + Niuas + + + + + + + + ORDER + 1904 + 1904 + + + Tongatapu + Tongatapu + + + + + + + + ORDER + 1905 + 1905 + + + Vava'u + Vava'u + + + + + + + + ORDER + 2000 + 2000 + + + Tuvalu + Tuvalu + + + + + + + + ORDER + 2001 + 2001 + + + Nanumea + Nanumea + + + + + + + + ORDER + 2002 + 2002 + + + Nanumanga + Nanumanga + + + + + + + + ORDER + 2003 + 2003 + + + Niutao + Niutao + + + + + + + + ORDER + 2004 + 2004 + + + Nui + Nui + + + + + + + + ORDER + 2005 + 2005 + + + Vaitupu + Vaitupu + + + + + + + + ORDER + 2006 + 2006 + + + Nukufetau + Nukufetau + + + + + + + + ORDER + 2007 + 2007 + + + Funafuti + Funafuti + + + + + + + + ORDER + 2008 + 2008 + + + Nukulaelae + Nukulaelae + + + + + + + + ORDER + 2009 + 2009 + + + Niulakita + Niulakita + + + + + + + + ORDER + 2100 + 2100 + + + Vanuatu + Vanuatu + + + + + + + + ORDER + 2101 + 2101 + + + Torba + Torba + + + + + + + + ORDER + 2102 + 2102 + + + Sanma + Sanma + + + + + + + + ORDER + 2103 + 2103 + + + Penama + Penama + + + + + + + + ORDER + 2104 + 2104 + + + Malampa + Malampa + + + + + + + + ORDER + 2105 + 2105 + + + Shefa + Shefa + + + + + + + + ORDER + 2106 + 2106 + + + Tafea + Tafea + + + + + + + + ORDER + 2200 + 2200 + + + Wallis and Futuna + Wallis-et-Futuna + + + + + + + + ORDER + 2201 + 2201 + + + Alo + Alo + + + + + + + + ORDER + 2202 + 2202 + + + Sigave + Sigave + + + + + + + + ORDER + 2203 + 2203 + + + Hahake + Hahake + + + + + + + + ORDER + 2204 + 2204 + + + Hihifo + Hihifo + + + + + + + + ORDER + 2205 + 2205 + + + Mua + Mua + + + + + + + + ORDER + 1600 + 1600 + + + Samoa + Samoa + + + + + + + + ORDER + 1601 + 1601 + + + Apia Urban Area + Apia Urban Area + + + + + + + + ORDER + 1602 + 1602 + + + North West Upolu + North West Upolu + + + + + + + + ORDER + 1603 + 1603 + + + Rest of Upolu + Rest of Upolu + + + + + + + + ORDER + 1604 + 1604 + + + Savaii + Savaii + + + + + + + + ORDER + 50000 + 50000 + + + Pacific region (excluding PNG) + Région du Pacifique (sans PNG) + + + + + ORDER + 60000 + 60000 + + + Melanesia (excluding PNG) + Mélanésie (sans PNG) + + + + + \ No newline at end of file diff --git a/tests/testthat/test_Codelists.R b/tests/testthat/test_Codelists.R index 33ba36e..10d220a 100644 --- a/tests/testthat/test_Codelists.R +++ b/tests/testthat/test_Codelists.R @@ -7,26 +7,43 @@ require(rsdmx, quietly = TRUE) require(testthat) context("SDMXCodelists") -test_that("Codelists - 2.0",{ +test_that("Codelists - 2.0", { file <- system.file("extdata", "SDMXCodelists_Example_2.0.xml", package = "rsdmx") xmlObj <- xmlParse(file) ns <- namespaces.SDMX(xmlObj) codelists <- SDMXCodelists(xmlObj, ns) expect_is(codelists, "SDMXCodelists") expect_equal(length(codelists@codelists), 1L) - + df <- as.data.frame(codelists) expect_is(df, "data.frame") }) -test_that("Codelists - 2.1",{ +test_that("Codelists - 2.1", { file <- system.file("extdata", "SDMXCodelists_Example_2.1.xml", package = "rsdmx") xmlObj <- xmlParse(file) ns <- namespaces.SDMX(xmlObj) codelists <- SDMXCodelists(xmlObj, ns) expect_is(codelists, "SDMXCodelists") expect_equal(length(codelists@codelists), 1L) - + + df <- as.data.frame(codelists) + expect_is(df, "data.frame") +} + +test_that("Hierarchical dodelists", { + file <- system.file("extdata", "SDMXCodelists_Example_hierarchical_2.1.xml", package = "rsdmx") + xmlObj <- xmlParse(file) + ns <- namespaces.SDMX(xmlObj) + codelists <- SDMXCodelists(xmlObj, ns) + expect_is(codelists, "SDMXCodelists") + expect_equal(length(codelists@codelists), 1L) + + # expect to read the right parentCode from the XML object when there is + expect_equal(codelists@codelists[[1]]@Code[[5]]@parentCode, "POL") + # expect to find an NA in parentCode when there is no parentCode in the XML object + expect_true(is.na(codelists@codelists[[1]]@Code[[1]]@parentCode)) + df <- as.data.frame(codelists) expect_is(df, "data.frame") }) \ No newline at end of file From 8253ab32187a164939d73e0fe1c2ffe4e865ea35 Mon Sep 17 00:00:00 2001 From: gvdr Date: Tue, 17 Dec 2024 14:18:36 +1100 Subject: [PATCH 3/4] missed trailing bracket in test --- tests/testthat/test_Codelists.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testthat/test_Codelists.R b/tests/testthat/test_Codelists.R index 10d220a..8dfabd4 100644 --- a/tests/testthat/test_Codelists.R +++ b/tests/testthat/test_Codelists.R @@ -29,7 +29,7 @@ test_that("Codelists - 2.1", { df <- as.data.frame(codelists) expect_is(df, "data.frame") -} +}) test_that("Hierarchical dodelists", { file <- system.file("extdata", "SDMXCodelists_Example_hierarchical_2.1.xml", package = "rsdmx") From c22da7dac34ae4dd520852c8d84eda93ce7e6185 Mon Sep 17 00:00:00 2001 From: gvdr Date: Tue, 17 Dec 2024 14:18:36 +1100 Subject: [PATCH 4/4] missed trailing bracket and little typo in test --- tests/testthat/test_Codelists.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/testthat/test_Codelists.R b/tests/testthat/test_Codelists.R index 10d220a..00898fc 100644 --- a/tests/testthat/test_Codelists.R +++ b/tests/testthat/test_Codelists.R @@ -29,9 +29,9 @@ test_that("Codelists - 2.1", { df <- as.data.frame(codelists) expect_is(df, "data.frame") -} +}) -test_that("Hierarchical dodelists", { +test_that("Hierarchical codelists", { file <- system.file("extdata", "SDMXCodelists_Example_hierarchical_2.1.xml", package = "rsdmx") xmlObj <- xmlParse(file) ns <- namespaces.SDMX(xmlObj)