Fix docker-api-install.sh #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how the test was constructed, it failed when UPGRADE was not set. Added a test for that case, and fixed to use `if; else` rather than `test && ...` to avoid the failing exit code I am unsure why this suddenly started failing, but possibly to do with the removal of the /var/apt/lists commit in the last PR.
madwort
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how the
test .. && ..was constructed, it failed with exit code 1 when UPGRADE was not set.Added test coverage for that case, and fixed to use
if; elserather thantest && ...to avoid the failing exit code.I am unsure why this suddenly started failing, but possibly to do with
the removal of the /var/apt/lists commit in the last PR.