Nexrad split cut removal #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kai Mühlbauer <kmuehlbauer@wradlib.org>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
+ Coverage 93.58% 93.61% +0.03%
==========================================
Files 26 26
Lines 5082 5075 -7
==========================================
- Hits 4756 4751 -5
+ Misses 326 324 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@aladinor Great! Can you maybe add a link to some documentation on SplitCut and AVSET? |
|
@aladinor Is this good to go? |
|
Hi @kmuehlbauer, Yeap. It is ready to go |
|
Thanks @aladinor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the split-cut comment because split-cuts are only applied in specific VCPs and cannot be determined solely based on the number of scans or sweeps. Instead, when the number of sweeps in NEXRAD Message 5 does not match the number of sweeps in NEXRAD Message 31, it may indicate that AVSET (Automated Volume Scan Evaluation and Termination) mode is enabled.
history.md