Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: correct retrieval of intermediate records in nexrad level2 reader #261

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

kmuehlbauer
Copy link
Collaborator

@kmuehlbauer kmuehlbauer commented Feb 3, 2025

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.57%. Comparing base (4c68528) to head (406f42a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   93.57%   93.57%           
=======================================
  Files          26       26           
  Lines        5041     5042    +1     
=======================================
+ Hits         4717     4718    +1     
  Misses        324      324           
Flag Coverage Δ
notebooktests 78.97% <100.00%> (+<0.01%) ⬆️
unittests 93.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmuehlbauer
Copy link
Collaborator Author

@aladinor Do you have an idea why the one zarr notebook is failing?

https://github.com/openradar/xradar/actions/runs/13116296298/job/36591356758?pr=261

File ~/micromamba/envs/xradar-notebook-tests/lib/python3.12/site-packages/xarray/backends/zarr.py:741, in ZarrStore.__init__(self, zarr_group, mode, consolidate_on_close, append_dim, write_region, safe_chunks, write_empty, close_store_on_close, use_zarr_fill_value_as_mask, cache_members)
    727 def __init__(
    728     self,
    729     zarr_group,
   (...)
    738     cache_members: bool = True,
    739 ):
    740     self.zarr_group = zarr_group
--> 741     self._read_only = self.zarr_group.read_only
    742     self._synchronizer = self.zarr_group.synchronizer
    743     self._group = self.zarr_group.path

zarr = 3.0.2

@aladinor
Copy link
Member

aladinor commented Feb 3, 2025

Hi @kmuehlbauer,

Zarr-Python V3 has changed the zarr. core.hierarchy.Group behavior which impacts datatree creation. I have been working on it. I already found a solution; however, now I have another issue when passing groups to xr.open_datatree(path, group="/path/to/group").

pydata/xarray@main...aladinor:xarray:dtree-zarrv3#:~:text=group_paths%3A%20list,store_member%2C

I am still working on it

@kmuehlbauer
Copy link
Collaborator Author

Ahh, what a mess ;-). Do you have an interim suggestion to at least get the notebooks/docs not failing?

@aladinor
Copy link
Member

aladinor commented Feb 3, 2025

I think we can pin Zarr to V2 for now until we solve these incompatibilities

- zarr

-  zarr<3.0

@kmuehlbauer kmuehlbauer enabled auto-merge (squash) February 4, 2025 07:23
@kmuehlbauer kmuehlbauer merged commit f38de38 into openradar:main Feb 4, 2025
12 checks passed
@kmuehlbauer kmuehlbauer mentioned this pull request Feb 4, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

NexradLevel2 Bug related to conflicting sizes for dimension
2 participants