-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: correct retrieval of intermediate records in nexrad level2 reader #261
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
=======================================
Coverage 93.57% 93.57%
=======================================
Files 26 26
Lines 5041 5042 +1
=======================================
+ Hits 4717 4718 +1
Misses 324 324
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@aladinor Do you have an idea why the one zarr notebook is failing? https://github.com/openradar/xradar/actions/runs/13116296298/job/36591356758?pr=261 File ~/micromamba/envs/xradar-notebook-tests/lib/python3.12/site-packages/xarray/backends/zarr.py:741, in ZarrStore.__init__(self, zarr_group, mode, consolidate_on_close, append_dim, write_region, safe_chunks, write_empty, close_store_on_close, use_zarr_fill_value_as_mask, cache_members)
727 def __init__(
728 self,
729 zarr_group,
(...)
738 cache_members: bool = True,
739 ):
740 self.zarr_group = zarr_group
--> 741 self._read_only = self.zarr_group.read_only
742 self._synchronizer = self.zarr_group.synchronizer
743 self._group = self.zarr_group.path zarr = 3.0.2 |
Hi @kmuehlbauer, Zarr-Python V3 has changed the pydata/xarray@main...aladinor:xarray:dtree-zarrv3#:~:text=group_paths%3A%20list,store_member%2C I am still working on it |
Ahh, what a mess ;-). Do you have an interim suggestion to at least get the notebooks/docs not failing? |
I think we can pin Zarr to V2 for now until we solve these incompatibilities Line 31 in 4cf4d6d
- zarr<3.0 |
history.md