From 9c94e2af60546805ae191ad81ec75d9f37c7e019 Mon Sep 17 00:00:00 2001
From: Ralph Castain <rhc@pmix.org>
Date: Tue, 5 Dec 2023 11:58:19 -0700
Subject: [PATCH] Remove daemonize option from prterun

Makes no sense to allow prterun to daemonize given that
it is intended to execute a single job and then terminate.
You can still run it in the background, if desired.

Signed-off-by: Ralph Castain <rhc@pmix.org>
---
 src/docs/show-help-files/help-prterun.rst | 7 -------
 src/mca/schizo/prte/schizo_prte.c         | 1 -
 src/tools/prte/prte.c                     | 3 ---
 3 files changed, 11 deletions(-)

diff --git a/src/docs/show-help-files/help-prterun.rst b/src/docs/show-help-files/help-prterun.rst
index bb752ee57e..860e679ba3 100644
--- a/src/docs/show-help-files/help-prterun.rst
+++ b/src/docs/show-help-files/help-prterun.rst
@@ -268,9 +268,6 @@ option to the help request as ``--help <option>``.
    * - ``--allow-run-as-root``
      - Allow execution as root (**STRONGLY DISCOURAGED**)
 
-   * - ``--daemonize``
-     - Daemonize the prterun and its daemons into the background
-
    * - ``--forward-signals <signals>``
      - Comma-delimited list of additional signals (names or integers) to forward
        to application processes [``none`` => forward nothing].
@@ -356,10 +353,6 @@ the directive appears.
 
 .. include:: /prrte-rst-content/cli-stream-buffering.rst
 
-[daemonize]
-
-Daemonize the prterun and the DVM daemons into the background
-
 [system-server]
 
 Start prterun and its daemons as the system server on their nodes
diff --git a/src/mca/schizo/prte/schizo_prte.c b/src/mca/schizo/prte/schizo_prte.c
index 3e1b56dda2..fe585c270f 100644
--- a/src/mca/schizo/prte/schizo_prte.c
+++ b/src/mca/schizo/prte/schizo_prte.c
@@ -149,7 +149,6 @@ static struct option prterunoptions[] = {
     PMIX_OPTION_DEFINE(PRTE_CLI_TUNE, PMIX_ARG_REQD),
 
     // DVM options
-    PMIX_OPTION_DEFINE(PRTE_CLI_DAEMONIZE, PMIX_ARG_NONE),
     PMIX_OPTION_DEFINE(PRTE_CLI_SET_SID, PMIX_ARG_NONE),
     PMIX_OPTION_DEFINE(PRTE_CLI_REPORT_PID, PMIX_ARG_REQD),
     PMIX_OPTION_DEFINE(PRTE_CLI_REPORT_URI, PMIX_ARG_REQD),
diff --git a/src/tools/prte/prte.c b/src/tools/prte/prte.c
index ff7ee6cb08..50280d6920 100644
--- a/src/tools/prte/prte.c
+++ b/src/tools/prte/prte.c
@@ -559,9 +559,6 @@ int main(int argc, char *argv[])
         prte_pmix_server_globals.singleton = strdup(opt->values[0]);
     }
 
-    /* Setup MCA params */
-    prte_register_params();
-
     /* default to a persistent DVM */
     prte_persistent = true;