Clarify author metadata check #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMeli
commented
Mar 1, 2024
RMeli
commented
Mar 1, 2024
| @@ -97,12 +97,17 @@ When a submission is ready to be accepted, we ask that the authors issue a new t | |||
| Optionally you can ask EditorialBot to generate a checklist with all the post-review steps running the command: `@editorialbot create post-review checklist` | |||
|
|
|||
| Pre-publication steps: | |||
| - (Optional) Run `@editorialbot create post-review checklist` | |||
There was a problem hiding this comment.
This is a bit repetitive since it's written just above, but if someone goes too quickly to the list of steps, this suggestion can be easily missed.
emdupre
reviewed
Mar 1, 2024
xuanxu
reviewed
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I asked the following on Slack:
and this PR changes the pre-publication steps according to the answers received.
My current understanding is that it is OK if the authors in the archive metadata don't match the authors on the paper as long as all the authors on the paper are included in the metadata (other contributors should be marked as such, if possible, instead of being marked as authors too).