From 37b7483c541e6512dadb42c718bfb68eb6c86d5b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= Date: Fri, 5 Apr 2024 14:10:08 +0200 Subject: [PATCH 1/7] Update title --- spec/controllers/home_controller_spec.rb | 2 +- spec/views/papers/show.html.erb_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/controllers/home_controller_spec.rb b/spec/controllers/home_controller_spec.rb index 6bd34d838..fc45dbf9e 100644 --- a/spec/controllers/home_controller_spec.rb +++ b/spec/controllers/home_controller_spec.rb @@ -7,7 +7,7 @@ it "should render home page" do get :index, format: :html expect(response).to be_successful - expect(response.body).to match /The Journal of Open Source Software/ + expect(response.body).to match /Proceedings of the JuliaCon Conferences/ end end diff --git a/spec/views/papers/show.html.erb_spec.rb b/spec/views/papers/show.html.erb_spec.rb index 3911bd55d..602573277 100644 --- a/spec/views/papers/show.html.erb_spec.rb +++ b/spec/views/papers/show.html.erb_spec.rb @@ -49,7 +49,7 @@ render template: "papers/show", formats: :html # Paper metadata - expect(rendered).to have_title("The Journal of Open Source Software: #{paper.scholar_title}") + expect(rendered).to have_title("Proceedings of the JuliaCon Conferences: #{paper.scholar_title}") expect(rendered).to have_css("meta[name='citation_title']", visible: false) expect(rendered).to have_css("meta[content='#{paper.scholar_title}']", visible: false) From 3247337c423e8f4f6a88638874b0cc74c7cdffda Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= Date: Fri, 5 Apr 2024 14:10:32 +0200 Subject: [PATCH 2/7] Fix launch date format --- config/settings-development.yml | 2 +- config/settings-production.yml | 2 +- config/settings-test.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/config/settings-development.yml b/config/settings-development.yml index a46fa1ac8..c96f6a7d2 100644 --- a/config/settings-development.yml +++ b/config/settings-development.yml @@ -7,7 +7,7 @@ logo_url: "http://proceedings.juliacon.org/logo_large.jpg" url: "https://proceedings.juliacon.org" editor_email: "admin@theoj.org" noreply_email: "admin@theoj.org" -launch_date: "2019" +launch_date: "2019-06-01" twitter: "@juliaconorg" mastodon_url: "FIXME" google_analytics: "UA-47852178-9" diff --git a/config/settings-production.yml b/config/settings-production.yml index 1e1cff6ac..8a32907ce 100644 --- a/config/settings-production.yml +++ b/config/settings-production.yml @@ -7,7 +7,7 @@ logo_url: "http://proceedings.juliacon.org/logo_large.jpg" url: "https://proceedings.juliacon.org" editor_email: "juliacon@julialang.org" noreply_email: "juliacon@julialang.org" -launch_date: "2019" +launch_date: "2019-06-01" twitter: "@juliaconorg" mastodon_url: "FIXME" google_analytics: "UA-47852178-9" diff --git a/config/settings-test.yml b/config/settings-test.yml index acf7b5f77..d3321bb14 100644 --- a/config/settings-test.yml +++ b/config/settings-test.yml @@ -7,7 +7,7 @@ logo_url: "http://proceedings.juliacon.org/logo_large.jpg" url: "https://proceedings.juliacon.org" editor_email: "admin@theoj.org" noreply_email: "admin@theoj.org" -launch_date: "2019" +launch_date: "2019-06-01" twitter: "@juliaconorg" mastodon_url: "FIXME" google_analytics: "UA-47852178-9" From 73e531a3cac8157a578f585c6d416c3a6b178045 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= Date: Fri, 5 Apr 2024 14:18:48 +0200 Subject: [PATCH 3/7] Fix paper specs --- spec/models/paper_spec.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/spec/models/paper_spec.rb b/spec/models/paper_spec.rb index cf9d95228..b08471259 100644 --- a/spec/models/paper_spec.rb +++ b/spec/models/paper_spec.rb @@ -260,8 +260,8 @@ it "should know how to generate a PDF URL for Google Scholar" do paper = create(:accepted_paper) - expect(paper.seo_url).to eq('http://joss.theoj.org/papers/10.21105/joss.00000') - expect(paper.seo_pdf_url).to eq('http://joss.theoj.org/papers/10.21105/joss.00000.pdf') + expect(paper.seo_url).to eq('https://proceedings.juliacon.org/papers/10.21105/jcon.00000') + expect(paper.seo_pdf_url).to eq('https://proceedings.juliacon.org/papers/10.21105/jcon.00000.pdf') end end @@ -269,8 +269,8 @@ it "should know how to generate a PDF URL for Google Scholar" do paper = create(:under_review_paper) - expect(paper.seo_url).to eq('http://joss.theoj.org/papers/48d24b0158528e85ac7706aecd8cddc4') - expect(paper.seo_pdf_url).to eq('http://joss.theoj.org/papers/48d24b0158528e85ac7706aecd8cddc4.pdf') + expect(paper.seo_url).to eq('https://proceedings.juliacon.org/papers/48d24b0158528e85ac7706aecd8cddc4') + expect(paper.seo_pdf_url).to eq('https://proceedings.juliacon.org/papers/48d24b0158528e85ac7706aecd8cddc4.pdf') end end @@ -444,7 +444,7 @@ is_expected.to match /#{Rails.application.settings['reviewers_lookup_url']}/ end - it { is_expected.to match "Currently, there isn't a JOSS editor assigned" } + it { is_expected.to match "Currently, there isn't a JCON editor assigned" } end end From 784f9d755dda5af2a9ea75c89c023ea997ae8f2a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= Date: Fri, 5 Apr 2024 14:32:56 +0200 Subject: [PATCH 4/7] joss -> jcon --- spec/controllers/papers_controller_spec.rb | 4 ++-- spec/system/papers/show_published_spec.rb | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/spec/controllers/papers_controller_spec.rb b/spec/controllers/papers_controller_spec.rb index 21600c5d4..7ac72d361 100644 --- a/spec/controllers/papers_controller_spec.rb +++ b/spec/controllers/papers_controller_spec.rb @@ -266,7 +266,7 @@ parsed_response = JSON.parse(response.body) expect(parsed_response['submitted']).to eq(3.days.ago.strftime('%d %B %Y')) expect(parsed_response['accepted']).to eq(2.days.ago.strftime('%d %B %Y')) - expect(parsed_response['doi']).to eq('10.21105/joss.00000') + expect(parsed_response['doi']).to eq('10.21105/jcon.00000') end it "should return paper's track short name" do @@ -412,7 +412,7 @@ expect(parsed_response["submitting_author"]).to eq("@foobar") expect(parsed_response["editor_name"]).to eq("Person McEditor") expect(parsed_response["editor_orcid"]).to eq("0000-0000-0000-1234") - expect(parsed_response["doi"]).to eq("10.21105/joss.00000") + expect(parsed_response["doi"]).to eq("10.21105/jcon.00000") expect(parsed_response["published_at"]).to_not be_nil end end diff --git a/spec/system/papers/show_published_spec.rb b/spec/system/papers/show_published_spec.rb index d0d92f683..b2820b551 100644 --- a/spec/system/papers/show_published_spec.rb +++ b/spec/system/papers/show_published_spec.rb @@ -2,17 +2,17 @@ feature "Published paper's show page" do before do - @accepted_paper = create(:accepted_paper, title: "Astronomy paper", doi: "10.21105/joss.00001", review_issue_id: 1) + @accepted_paper = create(:accepted_paper, title: "Astronomy paper", doi: "10.21105/jcon.00001", review_issue_id: 1) @accepted_paper.metadata['paper']['title'] = "Astronomy paper" @accepted_paper.metadata['paper']['authors'] = [{'given_name' => "Vera", 'last_name' => "Rubin"}] @accepted_paper.metadata['paper']['tags'] = ["Galaxy rotation curves"] @accepted_paper.save! - @retracted_paper = create(:retracted_paper, title: "Bad paper", doi: "10.21105/joss.00002", review_issue_id: 2) + @retracted_paper = create(:retracted_paper, title: "Bad paper", doi: "10.21105/jcon.00002", review_issue_id: 2) @retracted_paper.metadata['paper']['title'] = "Bad paper" @retracted_paper.save! - @retraction_notice = create(:accepted_paper, title: "Retraction notice for: Bad paper", doi: "10.21105/joss.00002R") + @retraction_notice = create(:accepted_paper, title: "Retraction notice for: Bad paper", doi: "10.21105/jcon.00002R") @retraction_notice.update(retracted_paper: @retracted_paper) end From 98a24519b0d1ba1742a69c6b960435b9b09b7f83 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= Date: Fri, 5 Apr 2024 14:33:09 +0200 Subject: [PATCH 5/7] Update org name --- spec/lib/repository_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/lib/repository_spec.rb b/spec/lib/repository_spec.rb index 41c3e358b..990f14296 100644 --- a/spec/lib/repository_spec.rb +++ b/spec/lib/repository_spec.rb @@ -54,7 +54,7 @@ it "returns false invitation is not created" do expect(Octokit).to receive(:user).and_return(OpenStruct.new(id: 33)) - expected_url = "https://api.github.com/orgs/openjournals/invitations" + expected_url = "https://api.github.com/orgs/JuliaCon/invitations" expected_params = {invitee_id: 33, team_ids: [1234]} exheaders = {"Authorization" => "token testGHtoken", "Content-Type" => "application/json", "Accept" => "application/vnd.github.v3+json"} expect(Faraday).to receive(:post).with(expected_url, expected_params.to_json, exheaders).and_return(OpenStruct.new(status: 404)) @@ -64,7 +64,7 @@ it "returns true if invitation is created" do expect(Octokit).to receive(:user).and_return(OpenStruct.new(id: 42)) - expected_url = "https://api.github.com/orgs/openjournals/invitations" + expected_url = "https://api.github.com/orgs/JuliaCon/invitations" expected_params = {invitee_id: 42, team_ids: [1234]} exheaders = {"Authorization" => "token testGHtoken", "Content-Type" => "application/json", "Accept" => "application/vnd.github.v3+json"} expect(Faraday).to receive(:post).with(expected_url, expected_params.to_json, exheaders).and_return(OpenStruct.new(status: 200)) From 498e17d39205280a19a808061127faef3c0634d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= Date: Fri, 5 Apr 2024 14:55:19 +0200 Subject: [PATCH 6/7] Update papers_factory.rb --- spec/factories/papers_factory.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/factories/papers_factory.rb b/spec/factories/papers_factory.rb index e6a2979c1..1c43299bc 100644 --- a/spec/factories/papers_factory.rb +++ b/spec/factories/papers_factory.rb @@ -47,7 +47,7 @@ state { 'retracted' } accepted_at { Time.now } review_issue_id { 0 } - sequence(:doi) {|n| "10.21105/jcon.00000#{n}" } + sequence(:doi) {|n| "10.21105/jcon.0000#{n}" } end factory :submitted_paper_with_sha do From bdd85d2db41abcc14cd1250847d4d0ff4af42fa8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= Date: Fri, 5 Apr 2024 14:56:34 +0200 Subject: [PATCH 7/7] Update origin for the dispatch_controller specs to work --- spec/fixtures/editor-pre-review-comment.json | 2 +- spec/fixtures/editor-review-comment.json | 2 +- spec/fixtures/editorialbot-pre-review-comment.json | 2 +- spec/fixtures/editorialbot-pre-review-opened.json | 2 +- spec/fixtures/editorialbot-review-comment.json | 2 +- spec/fixtures/editorialbot-review-edit.json | 2 +- spec/fixtures/editorialbot-review-labeled.json | 2 +- spec/fixtures/editorialbot-review-opened.json | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/spec/fixtures/editor-pre-review-comment.json b/spec/fixtures/editor-pre-review-comment.json index 430e31ed5..4b2f13c08 100644 --- a/spec/fixtures/editor-pre-review-comment.json +++ b/spec/fixtures/editor-pre-review-comment.json @@ -83,7 +83,7 @@ "id": 59520368, "node_id": "MDEwOlJlcG9zaXRvcnk1OTUyMDM2OA==", "name": "joss-reviews-testing", - "full_name": "openjournals/joss-reviews-testing", + "full_name": "JuliaCon/proceedings-review", "private": true, "owner": { "login": "openjournals", diff --git a/spec/fixtures/editor-review-comment.json b/spec/fixtures/editor-review-comment.json index 6cfe00f2f..9668fc1e2 100644 --- a/spec/fixtures/editor-review-comment.json +++ b/spec/fixtures/editor-review-comment.json @@ -83,7 +83,7 @@ "id": 59520368, "node_id": "MDEwOlJlcG9zaXRvcnk1OTUyMDM2OA==", "name": "joss-reviews-testing", - "full_name": "openjournals/joss-reviews-testing", + "full_name": "JuliaCon/proceedings-review", "private": true, "owner": { "login": "openjournals", diff --git a/spec/fixtures/editorialbot-pre-review-comment.json b/spec/fixtures/editorialbot-pre-review-comment.json index 2cd77eb55..a56971add 100644 --- a/spec/fixtures/editorialbot-pre-review-comment.json +++ b/spec/fixtures/editorialbot-pre-review-comment.json @@ -83,7 +83,7 @@ "id": 59520368, "node_id": "MDEwOlJlcG9zaXRvcnk1OTUyMDM2OA==", "name": "joss-reviews-testing", - "full_name": "openjournals/joss-reviews-testing", + "full_name": "JuliaCon/proceedings-review", "private": true, "owner": { "login": "openjournals", diff --git a/spec/fixtures/editorialbot-pre-review-opened.json b/spec/fixtures/editorialbot-pre-review-opened.json index 415b923b0..19cc296ad 100644 --- a/spec/fixtures/editorialbot-pre-review-opened.json +++ b/spec/fixtures/editorialbot-pre-review-opened.json @@ -52,7 +52,7 @@ "id": 59520368, "node_id": "MDEwOlJlcG9zaXRvcnk1OTUyMDM2OA==", "name": "joss-reviews-testing", - "full_name": "openjournals/joss-reviews-testing", + "full_name": "JuliaCon/proceedings-review", "private": true, "owner": { "login": "openjournals", diff --git a/spec/fixtures/editorialbot-review-comment.json b/spec/fixtures/editorialbot-review-comment.json index af59d392e..50036d078 100644 --- a/spec/fixtures/editorialbot-review-comment.json +++ b/spec/fixtures/editorialbot-review-comment.json @@ -83,7 +83,7 @@ "id": 59520368, "node_id": "MDEwOlJlcG9zaXRvcnk1OTUyMDM2OA==", "name": "joss-reviews-testing", - "full_name": "openjournals/joss-reviews-testing", + "full_name": "JuliaCon/proceedings-review", "private": true, "owner": { "login": "openjournals", diff --git a/spec/fixtures/editorialbot-review-edit.json b/spec/fixtures/editorialbot-review-edit.json index ba6331e7e..5a751ff44 100644 --- a/spec/fixtures/editorialbot-review-edit.json +++ b/spec/fixtures/editorialbot-review-edit.json @@ -102,7 +102,7 @@ "id": 52331602, "node_id": "MDEwOlJlcG9zaXRvcnk1MjMzMTYwMg==", "name": "joss-reviews-testing", - "full_name": "openjournals/joss-reviews-testing", + "full_name": "JuliaCon/proceedings-review", "private": false, "owner": { "login": "openjournals", diff --git a/spec/fixtures/editorialbot-review-labeled.json b/spec/fixtures/editorialbot-review-labeled.json index eee0a3637..2b4f83fcf 100644 --- a/spec/fixtures/editorialbot-review-labeled.json +++ b/spec/fixtures/editorialbot-review-labeled.json @@ -125,7 +125,7 @@ "id": 59520368, "node_id": "MDEwOlJlcG9zaXRvcnk1OTUyMDM2OA==", "name": "joss-reviews-testing", - "full_name": "openjournals/joss-reviews-testing", + "full_name": "JuliaCon/proceedings-review", "private": true, "owner": { "login": "openjournals", diff --git a/spec/fixtures/editorialbot-review-opened.json b/spec/fixtures/editorialbot-review-opened.json index 4768566ac..6b10d9968 100644 --- a/spec/fixtures/editorialbot-review-opened.json +++ b/spec/fixtures/editorialbot-review-opened.json @@ -52,7 +52,7 @@ "id": 59520368, "node_id": "MDEwOlJlcG9zaXRvcnk1OTUyMDM2OA==", "name": "joss-reviews-testing", - "full_name": "openjournals/joss-reviews-testing", + "full_name": "JuliaCon/proceedings-review", "private": true, "owner": { "login": "openjournals",