-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8353568: SEGV_BNDERR signal code adjust definition #24441
Conversation
@tstuefe this is the PR for for suggestion regarding SEGV_BNDERR signal code handling. |
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good and imho trivial. Thanks!
Thanks for the review ! /integrate |
Going to push as commit 6abf4e6.
Your commit was automatically rebased without conflicts. |
There was a remark from Thomas Stuefe in openjdk/jdk24u#175 .
The idea was to add a static assert for SEGV_BNDERR sig-code.
The static assert will alert us if we build on a newer Linux version and turns out we were wrong with our assumed number.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24441/head:pull/24441
$ git checkout pull/24441
Update a local copy of the PR:
$ git checkout pull/24441
$ git pull https://git.openjdk.org/jdk.git pull/24441/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24441
View PR using the GUI difftool:
$ git pr show -t 24441
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24441.diff
Using Webrev
Link to Webrev Comment