8353365: TOUCH_ASSERT_POISON clears GetLastError()

[dholmes-ora]

This is a very simple fix to save/restore the "last error" value on Windows, so that the TOUCH_ASSERT_POISON mechanism used in assert/guarantee/fatal, does not clear it.

Testing

• new Windows-only gtest added to vmErrors test group
• tiers 103 sanity

Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353365: TOUCH_ASSERT_POISON clears GetLastError() (Bug - P4)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer) Review applies to c080c068
• Julian Waters (@TheShermanTanker - Committer) Review applies to c080c068
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24435/head:pull/24435
$ git checkout pull/24435

Update a local copy of the PR:
$ git checkout pull/24435
$ git pull https://git.openjdk.org/jdk.git pull/24435/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24435

View PR using the GUI difftool:
$ git pr show -t 24435

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24435.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353365: TOUCH_ASSERT_POISON clears GetLastError()

Reviewed-by: kbarrett, stuefe, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

• 32d6d03: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java
• 39549f8: 8352116: Deadlock with GCLocker and JVMTI after JDK-8192647
• d63b561: 8353188: C1: Clean up x86 backend after 32-bit x86 removal
• d1e91fc: 8353344: RISC-V: Detect and enable several extensions for debug builds
• 6abf4e6: 8353568: SEGV_BNDERR signal code adjust definition
• 6d9ece7: 8351949: RISC-V: Cleanup and enable store-load peephole for membars
• 97ed536: 8346989: C2: deoptimization and re-execution cycle with Math.*Exact in case of frequent overflow
• 660b17a: 8350852: Implement JMH benchmark for sparse CodeCache
• 6d37e63: 8353753: Remove unnecessary forward declaration in oop.hpp
• 9bb804b: 8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java
• ... and 60 more: https://git.openjdk.org/jdk/compare/6970cf6ac69864e7027138746361e7da1983c24d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9a03b3bf)
• 00: Full (c080c068)

[tstuefe]

Oh, sorry for that. Thanks @stefank @dholmes-ora for finding and fixing this. The patch is fine.

I wonder whether we have the same problem on Posix with errno, but I assume we don't call any functions there that modify errno.

[TheShermanTanker]

Simple enough for me to review, so I'll give it a +1, just one trivial question

[kimbarrett]

Oh, sorry for that. Thanks @stefank @dholmes-ora for finding and fixing this. The patch is fine.

I wonder whether we have the same problem on Posix with errno, but I assume we don't call any functions there that modify errno.

Same problem exists for posix, but we already preserve errno:

jdk/src/hotspot/os/posix/signals_posix.cpp

Lines 564 to 566 in 41d4a0d

	// Preserve errno value over signal handler.
	// (note: RAII ok here, even with JFR thread crash protection, see below).
	ErrnoPreserver ep;

That behavior goes back to https://bugs.openjdk.org/browse/JDK-6749267, fixed in jdk8.

[kimbarrett]

Looks good.

[dholmes-ora]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit 3951a8e.
Since your change was applied there have been 95 commits pushed to the master branch:

• fd2734e: 8353585: Provide ChoiceFormat#parse(String, ParsePosition) tests
• e266eba: 8352972: PPC64: Intrinsify Unsafe::setMemory
• a8dfcf5: 8353322: Specification of ChoiceFormat#parse(String, ParsePosition) is inadequate
• ... and 92 more: https://git.openjdk.org/jdk/compare/6970cf6ac69864e7027138746361e7da1983c24d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit 3951a8e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.