8352620: C2: rename MemNode::memory_type() to MemNode::value_basic_type()

[sarannat]

Description: The current name MemNode::memory_type() is misleading because the returned type is a property of the value that is loaded/stored, not the memory that is accessed. Usually, the two of them match, but for mismatched memory accesses (arising e.g. from using Unsafe or memory segments) they might differ, e.g. one might store a value of type 'short' into an array of elements of type 'long'. The proposal was to rename MemNode::memory_type() to MemNode::value_basic_type() to clarify these cases.

Solution: Replaced all occurrence of MemNode::memory_type() with MemNode::value_basic_type()

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352620: C2: rename MemNode::memory_type() to MemNode::value_basic_type() (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24427/head:pull/24427
$ git checkout pull/24427

Update a local copy of the PR:
$ git checkout pull/24427
$ git pull https://git.openjdk.org/jdk.git pull/24427/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24427

View PR using the GUI difftool:
$ git pr show -t 24427

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24427.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sarannat! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@sarannat The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f2305491)

[robcasloz]

The value of this comment is debatable, but I think it is best to not remove it in this RFE (just rename memory_type to value_basic_type), to preserve the original scope of the RFE.