8353669: IGV: dump OOP maps for MachSafePoint nodes

[robcasloz]

This changeset dumps the OOP map of each MachSafePoint when available, i.e. at the Final Code phase. This should make it easier to learn about and diagnose OOP map building issues:

Testing

• tier1 (windows-x64, linux-x64, linux-aarch64, macosx-x64, and macosx-aarch64; release and debug mode).
• Tested IGV manually on a few selected graphs. Tested automatically that dumping thousands of graphs does not trigger any assertion failure (by running java -Xcomp -XX:PrintIdealGraphLevel=1).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353669: IGV: dump OOP maps for MachSafePoint nodes (Enhancement - P4)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24422/head:pull/24422
$ git checkout pull/24422

Update a local copy of the PR:
$ git checkout pull/24422
$ git pull https://git.openjdk.org/jdk.git pull/24422/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24422

View PR using the GUI difftool:
$ git pr show -t 24422

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24422.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353669: IGV: dump OOP maps for MachSafePoint nodes

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 75 new commits pushed to the master branch:

• 9844c1c: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources
• fb955bc: 8353267: jmod create finds the wrong set of packages when class file are in non-package location
• 80ff7b9: 8353695: RISC-V: compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java is failing with Zvkn
• ... and 72 more: https://git.openjdk.org/jdk/compare/bd74922157230c866802b4c5269da81e872525aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@robcasloz The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (91a1b2b7)

[chhagedorn]

Looks good!

How can it be visualized inside the node? Have you adapted some filter? AFAIU, you only dump an additional node property which is shown in the IGV node properties view.

[robcasloz]

Looks good!

Thanks for reviewing, Christian!

How can it be visualized inside the node? Have you adapted some filter? AFAIU, you only dump an additional node property which is shown in the IGV node properties view.

For the above example, I just set the Node Text setting in IGV's Options window to

[idx] [name]
[oopmap]

[chhagedorn]

I see, thanks! So, I guess it's not something we should have as a filter like showing type info?

[robcasloz]

I see, thanks! So, I guess it's not something we should have as a filter like showing type info?

Right, I would advocate for not creating a filter for it yet, to avoid overloading the filter list. If we find in the future that the property is generally useful to display in the node labels, we might consider adding a filter then (or possibly extending the existing Show custom node info filter).

[chhagedorn]

Sounds good!

[TobiHartmann]

Looks good to me too.

[robcasloz]

Looks good to me too.

Thanks for reviewing, Tobias!

[robcasloz]

/integrate

[openjdk]

Going to push as commit fda5eec.
Since your change was applied there have been 76 commits pushed to the master branch:

• ea07e71: 8352256: ObjectSynchronizer::quick_notify misses JFR event notification path
• 9844c1c: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources
• fb955bc: 8353267: jmod create finds the wrong set of packages when class file are in non-package location
• ... and 73 more: https://git.openjdk.org/jdk/compare/bd74922157230c866802b4c5269da81e872525aa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robcasloz Pushed as commit fda5eec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.