-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8348282: Add option for syntax highlighting in javadoc snippets #24417
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build change looks trivially good.
/reviewers 2 reviewer
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlOptions.java
Outdated
Show resolved
Hide resolved
Here's a selection of code fragments from the sample docs using syntax highlighting: |
Please review a change to add a
javadoc
option to enable syntax highlighting for code fragments in snippets and<pre><code>
tags. The new--syntax-highlight
option uses the [highlight.js] JavaScript library and supports Java, Properties, XML, HTML and JSON. The option is enabled in the JDK API docs target, generated output is available here.Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24417/head:pull/24417
$ git checkout pull/24417
Update a local copy of the PR:
$ git checkout pull/24417
$ git pull https://git.openjdk.org/jdk.git pull/24417/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24417
View PR using the GUI difftool:
$ git pr show -t 24417
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24417.diff
Using Webrev
Link to Webrev Comment