Speed up super admin dashboard #13147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Div is the default element in HAML, so we don't need to specify it. https://haml.info/docs/yardoc/file.REFERENCE.html#implicit-div-elements
Div is the default element in HAML, so we don't need to specify it.
I thought about reducing it further, but maybe people are used to having a large list. Let's see how this performs
I searched the codebase for these keys, but couldn't find them The next ones look unused too. I thought we had a plugin to help with that..
And check fo unused translations: bundle exec i18n-tasks unused -l en -f key-values | wc -l 1277 Wow, really??
That brings the count down to 'only' 1057. There's probably a lot of other keys that are dynamically generated, I did *not* review them all. We could consider saving the output of this command to a todo file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
It takes so long to load because there's so many enterprises. We don't need to see those.
This has been bugging me since.. forever.
Also did some code cleanup, and removed some unused translation keys.
I tried to use gem i18n-tasks to discover unused keys, but it seemed too risky to clean up too many at once.
If code review passes, maybe it's worth running this past an instance manager too.
What should we test?
go make a coffeeIt loads quickly!Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates