Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds coverage on supplier option to charge tax #13142

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

filipefurtad0
Copy link
Contributor

@filipefurtad0 filipefurtad0 commented Feb 11, 2025

What? Why?

We have basic coverage for both system and unit testing. There are a couple scenarios which would be relevant to additionally cover, at the unit level:

  • supplier charges/does not charge tax -> tax values are included/excluded from the report
  • supplier charges included tax -> tax values are included and calculated correctly on report
  • distributor fees added to the incoming section of the OC -> these do not appear on the report

What should we test?

None.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@filipefurtad0 filipefurtad0 marked this pull request as draft February 11, 2025 14:21
@filipefurtad0 filipefurtad0 marked this pull request as ready for review February 13, 2025 03:47
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Nice to have all this covered.

@mkllnk mkllnk merged commit ca256f0 into openfoodfoundation:master Feb 14, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants