-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: Category translations #9673
Conversation
ERROR - nl:yoghurts-met-fruit-en-suiker already is associated to en:yogurt-with-fruits-and-sugar (categories) - nl:yoghurts-met-fruit-en-suiker cannot be mapped to entry en:yogurts-with-fruits-and-sugar |
|
yes, I commented that 2hours ago ;-) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9673 +/- ##
==========================================
+ Coverage 44.17% 49.54% +5.36%
==========================================
Files 65 67 +2
Lines 20557 20650 +93
Branches 4966 4980 +14
==========================================
+ Hits 9082 10231 +1149
+ Misses 10294 9131 -1163
- Partials 1181 1288 +107 ☔ View full report in Codecov by Sentry. |
taxonomies/categories.txt
Outdated
nl:Gevogelte sandwiches | ||
es:Bocadillos de aves | ||
it:Panini di carne avicola | ||
pt:Sanduíches de aves | ||
bg:Сандвичи с птици | ||
es:Sándwiches de aves | ||
it:Panini al pollame | ||
nl:Pluimvee sandwiches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nl:Gevogelte sandwiches | |
es:Bocadillos de aves | |
it:Panini di carne avicola | |
pt:Sanduíches de aves | |
bg:Сандвичи с птици | |
es:Sándwiches de aves | |
it:Panini al pollame | |
nl:Pluimvee sandwiches | |
nl:Gevogelte sandwiches, pluimvee sandwiches | |
es:Bocadillos de aves | |
it:Panini di carne avicola | |
pt:Sanduíches de aves | |
bg:Сандвичи с птици | |
es:Sándwiches de aves | |
it:Panini al pollame |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
found synonyms. See suggestion
ERROR - nl:dolce-gusto-compatibele-koffiecapsules already is associated to en:dolce-gusto-compatible-coffee-capsules (categories) - nl:dolce-gusto-compatibele-koffiecapsules cannot be mapped to entry en:dolce-gusto-compatible-capsules |
@benbenben2 I did a substantial commit from another branch on my laptop after your review. Could you have a look at that commit ? If everything still ok, please tell me so and I merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one comment about English translation.
|
* Update categories.txt * Update categories.txt * Update categories.txt * Update categories.txt * Update categories.txt * Update categories.txt
What
taxonomy: Category translations