chore: adding beverage preparations #9615
Conversation
github-actions
bot
added
🧬 Taxonomies
aleene
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9615 +/- ##
=======================================
Coverage 49.45% 49.45%
=======================================
Files 67 67
Lines 20645 20645
Branches 4978 4978
=======================================
Hits 10209 10209
Misses 9139 9139
Partials 1297 1297 ☔ View full report in Codecov by Sentry. |
taxonomies/categories.txt
Outdated
| en:Beverage preparations | ||
| es:Preparaciones de bebidas | ||
| de:Getränkezubereitungen | ||
| fr:Préparations pour boissons | ||
| it:Preparati per bevande | ||
| nl:Drankbereidingen | ||
| description:en:Any product which purpose it is to create a beverage which uses water (hor or cold) in some way (diluting, infusing, dissolving, etc). |
There was a problem hiding this comment.
I see it's not in Beverage category, But can't it change Nutri-Score computation ?
See is_beverage_for_nutrition_score_2023 and is_beverage_for_nutrition_score_2021 in Food.pm, we rely on the category.
There was a problem hiding this comment.
The Nutriscore was under the subcategories.
There was a problem hiding this comment.
@aleene: I think it makes sense to put "beverage preparations" under "beverages". Tea bags etc. have nutrition facts for the prepared beverage, and are considered beverages for the Nutri-Score. It's also where users are likely to look for them.
There was a problem hiding this comment.
Can do, but then we miss out on the category ready to drink beverages.
There was a problem hiding this comment.
Could we add a category under beverages to indicate ready to drink beverages?
There was a problem hiding this comment.
Well do we really need one? It's a bit strange to add a category that should be applied to 99% of beverages.
Or maybe another possibility could be to have a parent "Beverages and beverages preparations"?
There was a problem hiding this comment.
Thats why I wanted to set the preparations apart, but we can create a super as you suggested.
|
What
Introduction of a new super category, which helps to distinguish between beverages (ready to drink) and products that form the basis of beverages (after adding a fluid (water/milk/etc) to dissolve, dilute, infuse, etc).
Additional subcategories could be added if necessary.
After the categories are available some products need clean up (esp teas).