Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facet mixes food and beauty #11330

Open
aleene opened this issue Feb 6, 2025 · 9 comments
Open

Facet mixes food and beauty #11330

aleene opened this issue Feb 6, 2025 · 9 comments
Labels
🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org OxF

Comments

@aleene
Copy link
Contributor

aleene commented Feb 6, 2025

What

The food facet search mixes food and beauty products. When I click on a beauty product I am referred to the obf site

Steps to reproduce the behavior

  1. https://nl.openfoodfacts.org/status/voedingswaarden-invullen/status/foto-van-de-voedingswaarden-geselecteerd
  2. See error

Expected behavior

no beauty products

Screenshot/Mockup/Before-After

Image

Type of device

  • Browser: Safari
@teolemon
Copy link
Member

teolemon commented Feb 6, 2025

  • We have a PR that will allow moving a lot of cosmetics to Open Beauty Facts.
  • Meanwhile, the safest bet is to add "Open Beauty Facts" as a category whenever you spot one.

@teolemon teolemon added 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org OxF labels Feb 6, 2025
@github-project-automation github-project-automation bot moved this to To Discuss & Validate in 🧴 Open Beauty Facts Feb 6, 2025
@teolemon
Copy link
Member

teolemon commented Feb 6, 2025

@john-gom @stephanegigandet I can reproduce, on a year old product, edited in 2024.

@aleene
Copy link
Contributor Author

aleene commented Feb 6, 2025

The product are already on OBF or OPF! It seems just a facet issue.

@john-gom
Copy link
Contributor

john-gom commented Feb 6, 2025

What redis event do we generate when a product is moved from OFF to OBF, etc.? It might be the off-query is not being updated when that happens. Can I have specific examples of a product and facet that aren't right?

@aleene
Copy link
Contributor Author

aleene commented Feb 6, 2025

This one turns op in my food facet: https://nl.openbeautyfacts.org/product/3337875816809

@aleene
Copy link
Contributor Author

aleene commented Feb 6, 2025

@baslia
Copy link

baslia commented Feb 10, 2025

Will the product manually labeled as "Open Beaty Facts" via the hunger game website, be moved as well to the correct website ?

@stephanegigandet
Copy link
Contributor

The product is in both the off and obf mongodb databases, with product_type "beauty". We'll need to investigate how it happened.

12k products are in the same case

off> db.products.find({code: "3770017359053"}, {code: 1, id: 1, product_type: 1})
[
  {
    _id: '3770017359053',
    id: '3770017359053',
    code: '3770017359053',
    product_type: 'beauty'
  }
]
off> db.products.count({ product_type: "beauty"})
DeprecationWarning: Collection.count() is deprecated. Use countDocuments or estimatedDocumentCount.
12566

@stephanegigandet
Copy link
Contributor

off> db.products.count({ product_type: "petfood"})
1402
off> db.products.count({ product_type: "product"})
4138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org OxF
Projects
Status: To discuss and validate
Status: To Discuss & Validate
Development

No branches or pull requests

5 participants