fix(dotnet-sdk): Fix broken rate limit handling #493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This unhelpfully deadlocked my test pipeline today. This code hasn't been touched for 3 years and has always been broken as far as I can tell. The tests also made the incorrect assumption about the header shape.
In the test suite, change the header configuration to:
response.Headers.Add(RateLimitParser.RateLimitHeader.LimitResetIn, DateTimeOffset.UtcNow.AddSeconds(10).ToUnixTimeSeconds().ToString());
And the assertion to:
Assert.InRange(error.ResetInMs!.Value, 0, 10000);
References
Closes openfga/dotnet-sdk#76
Review Checklist
main