fix(java-sdk): fix token validity check for expiry #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjames
force-pushed
the
fix/java-sdk-token-exp-check
branch
from
f7dbd5a to
e03a16d
Compare
ewanharris
approved these changes
Jan 25, 2024
rhamzeh
approved these changes
Jan 25, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in
AccessToken#isValid()that caused it to return false when the token is valid, resulting in extraneous calls to fetch new tokens.Description
Fixes the logic used to check if the token is valid based on its expiry.
References
openfga/java-sdk#48
Review Checklist
main