Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes to config and readme #107

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix: fixes to config and readme #107

merged 2 commits into from
Jun 11, 2024

Conversation

ewanharris
Copy link
Member

Description

Copies across some changes from the sdk-generator repo

References

openfga/sdk-generator#371
openfga/sdk-generator#372 (will close #104)

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested review from a team as code owners June 11, 2024 10:41
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.59%. Comparing base (47a15e1) to head (93a526b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   23.57%   23.59%   +0.02%     
==========================================
  Files          95       95              
  Lines        9953     9956       +3     
==========================================
+ Hits         2346     2349       +3     
  Misses       7357     7357              
  Partials      250      250              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhamzeh rhamzeh changed the title Copy changes from sdk-generator fix: fixes to config and readme Jun 11, 2024
@rhamzeh rhamzeh added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 97c03bc Jun 11, 2024
9 checks passed
@rhamzeh rhamzeh deleted the chore/copy-changes branch June 11, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README content display format is incorrect
5 participants