Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mode=serializing be fully backwards compatible with the original watchdog #32

Closed
thomasjpfan opened this issue Oct 3, 2018 · 2 comments

Comments

@thomasjpfan
Copy link

For of-watchdog to take the place of the original watchdog, it should be fully backwards compatible with the original watchdog.

Expected Behavior

Support environmental variables cgi_headers, marshal_request, and combine_output with their corresponding feature.

Current Behavior

The above features are not fully supported.

Possible Solution

Migrate over the tests and code from the original watchdog.

Context

Maintaining two versions of watchdog doubles the amount of work one needs to do. Once of-watchdog in serializing mode becomes backwards compatible, it can replace the original watchdog while the other modes can get worked on.

@sargun
Copy link
Contributor

sargun commented Apr 4, 2019

@alexellis is this and #10 the only remaining items to be able to supplant the old watchdog?

@alexellis
Copy link
Member

Hi I am not clear what the question is. There are two supported watchdogs at present.

For the forking mode we have the classic watchdog and for HTTP mode we are using this watchdog. Both watchdogs are used by the end user community in templates.

https://docs.openfaas.com/architecture/watchdog/

@openfaas openfaas locked and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants