-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add drag and drop to LIBRARY_SUPPORTED_BLOCKS
#1651
base: master
Are you sure you want to change the base?
feat: Add drag and drop to LIBRARY_SUPPORTED_BLOCKS
#1651
Conversation
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1651 +/- ##
=======================================
Coverage 93.24% 93.24%
=======================================
Files 1101 1101
Lines 21859 21859
Branches 4643 4722 +79
=======================================
Hits 20383 20383
Misses 1411 1411
Partials 65 65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for your work, @ChrisChV!
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
PS: I had to run npm run build
in the authoring folder to trigger the build
Description
Add drag and drop to
LIBRARY_SUPPORTED_BLOCKS
to enable it by defaultSupporting information
Testing instructions
tutor config save
New
button and verify that you can see theDrag Drop
button.Other information
N/A