Skip to content

Commit

Permalink
fix: filter lti_external in get_backend_provider
Browse files Browse the repository at this point in the history
  • Loading branch information
ilee2u committed Mar 12, 2024
1 parent df4c4f3 commit 447f3a6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
1 change: 0 additions & 1 deletion edx_proctoring/apps.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
'help_center_article_url',
'integration_specific_email',
'learner_notification_from_email',
'lti_external',
'needs_oauth',
'organization',
'passing_statuses',
Expand Down
6 changes: 6 additions & 0 deletions edx_proctoring/backends/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,10 @@ def get_backend_provider(exam=None, name=None):
return None
if exam['backend']:
name = exam['backend']
if name == 'lti_external':
# `get_backend_provider()` is called in many places in edx-proctoring, so this filter for
# LTI providers needs to be in this function. Not sure if this is the exact right place
# Also not sure what I should return here
return None

Check warning on line 24 in edx_proctoring/backends/__init__.py

View check run for this annotation

Codecov / codecov/patch

edx_proctoring/backends/__init__.py#L24

Added line #L24 was not covered by tests
return apps.get_app_config('edx_proctoring').get_backend(name=name)

0 comments on commit 447f3a6

Please sign in to comment.