-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add publish status to library meilisearch index #36031
Conversation
Thanks for the pull request, @DanielVZ96! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
Adds the publish status field to the libraries v2 meilisearch index in order to support filtering by component publish status: published, modified, never.
5fb0549
to
ecaf889
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working great, but I'm not sure that we need it?
If we do keep it, we need one more test, so I'm happy to conditionally approve. 👍
- I tested this using the test instructions for feat: allow filtering library by publish status frontend-app-authoring#1570
- I read through the code
-
I checked for accessibility issuesN/A - Includes some documentation
-
User-facing strings are extracted for translationN/A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this using the test instructions for feat: allow filtering library by publish status frontend-app-authoring#1570
- I read through the code
-
I checked for accessibility issues by using my keyboard to navigateN/A - Includes documentation -- code comments
-
User-facing strings are extracted for translationN/A
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
…edx#36031) Adds the publish status field to the libraries v2 meilisearch index in order to support filtering by component publish status: published, modified, never.
Description
Adds the publish status field to the libraries v2 meilisearch index in order to support filtering by component publish status: published, modified, never.
Supporting information
Testing instructions
tutor dev exec cms bash -c './manage.py cms reindex_studio --experimental '
Deadline
ASAP
Other information
Private-Ref