Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add step param #2135

Merged
merged 5 commits into from
Dec 7, 2023
Merged

fix: add step param #2135

merged 5 commits into from
Dec 7, 2023

Conversation

jansenk
Copy link
Contributor

@jansenk jansenk commented Dec 7, 2023

Add a "step" param to the "create assessment" MFE endpoint. This controls which type of assessment we create.

@jansenk jansenk requested a review from a team as a code owner December 7, 2023 18:27
@jansenk jansenk force-pushed the jkantor/add-step-param branch from 00acbdc to 1480964 Compare December 7, 2023 18:28
@jansenk jansenk changed the title Jkantor/add step param fix: add step param Dec 7, 2023
@jansenk jansenk force-pushed the jkantor/add-step-param branch from 0286375 to 4944d60 Compare December 7, 2023 19:47
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4012e00) 94.98% compared to head (7d38565) 94.95%.

Files Patch % Lines
openassessment/xblock/ui_mixins/mfe/mixin.py 83.33% 0 Missing and 1 partial ⚠️
...nassessment/xblock/ui_mixins/mfe/test_mfe_mixin.py 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2135      +/-   ##
==========================================
- Coverage   94.98%   94.95%   -0.04%     
==========================================
  Files         191      191              
  Lines       20506    20518      +12     
  Branches     1857     1859       +2     
==========================================
+ Hits        19477    19482       +5     
- Misses        772      776       +4     
- Partials      257      260       +3     
Flag Coverage Δ
unittests 94.95% <94.59%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansenk jansenk merged commit eafd1e1 into master Dec 7, 2023
5 of 7 checks passed
@jansenk jansenk deleted the jkantor/add-step-param branch December 7, 2023 20:02
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
* fix: add step param to assess view

* style: remove unused import

* test: typo

* test: fix test failures

* chore: version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants