Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: BFF integration updates (round 2) #2121

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Conversation

nsprenkle
Copy link
Contributor

@nsprenkle nsprenkle commented Nov 21, 2023

TL;DR - More tweaks for ORA UI BFF, before launch.

What changed?

  • Hide deleted files (download URL = None) from returned file list.
  • Update static assets.
  • Update translations.
  • Bump ora to 6.0.6.

Developer Checklist

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (22f232b) 95.01% compared to head (6f44ebd) 95.01%.

Files Patch % Lines
...ent/xblock/ui_mixins/mfe/submission_serializers.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2121      +/-   ##
==========================================
- Coverage   95.01%   95.01%   -0.01%     
==========================================
  Files         191      191              
  Lines       20537    20538       +1     
  Branches     1859     1860       +1     
==========================================
  Hits        19514    19514              
  Misses        767      767              
- Partials      256      257       +1     
Flag Coverage Δ
unittests 95.01% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@nsprenkle nsprenkle force-pushed the feat/bff-integration branch from d133a68 to 6f44ebd Compare November 22, 2023 16:05
@nsprenkle nsprenkle merged commit 7b75081 into master Nov 22, 2023
@nsprenkle nsprenkle deleted the feat/bff-integration branch November 22, 2023 16:20
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
* refactor: hide deleted files from file list

* chore: build static assets

* chore: update translations

* chore: bump ORA to 6.0.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants