Skip to content

Commit

Permalink
chore: fix quality checks
Browse files Browse the repository at this point in the history
  • Loading branch information
BryanttV committed Mar 5, 2024
1 parent 692ae1a commit e12693d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions openassessment/xblock/static/js/src/lms/oa_response.js
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export class ResponseView {
);

// Install a click handler for the resubmission button
sel.find(".reset__submission").click((eventObject) => {
sel.find('.reset__submission').click((eventObject) => {
eventObject.preventDefault();
view.handleResubmissionClicked();
});
Expand Down Expand Up @@ -557,9 +557,9 @@ export class ResponseView {
* */
handleResubmissionClicked() {
const view = this;
const title = gettext("Confirm Resubmission");
const title = gettext('Confirm Resubmission');
const msg = gettext(
"You're about to reset your response for this assignment. Are you sure you want to do this?"
'You\'re about to reset your response for this assignment. Are you sure you want to do this?'

Check failure on line 562 in openassessment/xblock/static/js/src/lms/oa_response.js

View workflow job for this annotation

GitHub Actions / Tests (ubuntu-20.04, 3.8, 16, quality)

Missing trailing comma
);
this.confirmationDialog.confirm(
title,
Expand All @@ -580,7 +580,7 @@ export class ResponseView {
})
.fail((errMsg) => {
if (errMsg) {
this.baseView.toggleActionError("submit", errMsg);
this.baseView.toggleActionError('submit', errMsg);
}
});
}
Expand Down
2 changes: 1 addition & 1 deletion openassessment/xblock/static/js/src/oa_server.js
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ export class Server {
* and which fails with an error message otherwise.
*/
resetSubmission() {
const url = this.url("reset_submission");
const url = this.url('reset_submission');
return $.Deferred((defer) => {
$.ajax({
type: 'POST',
Expand Down
6 changes: 3 additions & 3 deletions openassessment/xblock/utils/allow_resubmission.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ def allow_resubmission(config_data, workflow_data, submission_data: dict) -> boo
bool: True if the learner's submission is eligible for retry, False otherwise.
"""
return (
allow_learner_resubmissions(config_data)
and not submission_date_exceeded(config_data, submission_data)
and not has_been_graded(workflow_data)
allow_learner_resubmissions(config_data) and
not submission_date_exceeded(config_data, submission_data) and
not has_been_graded(workflow_data)
)


Expand Down

0 comments on commit e12693d

Please sign in to comment.