Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing I/O engine crashes #1549

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Fixing I/O engine crashes #1549

merged 3 commits into from
Dec 5, 2023

Conversation

dsavitskiy
Copy link
Contributor

No description provided.

@auto-assign auto-assign bot requested a review from chriswldenyer November 27, 2023 08:42
@dsavitskiy
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Nov 27, 2023
Try #1549:
021852b
tiagolobocastro
tiagolobocastro approved these changes Nov 27, 2023
View reviewed changes
io-engine/src/bdev/nexus/nexus_bdev.rs Show resolved Hide resolved
io-engine/src/bdev/nexus/nexus_bdev_children.rs Show resolved Hide resolved
ci.nix Show resolved Hide resolved
io-engine/src/subsys/nvmf/subsystem.rs Outdated Show resolved Hide resolved
nix/lib/rust.nix Outdated Show resolved Hide resolved
@bors-openebs-mayastor
Copy link

try

Timed out.

@dsavitskiy
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Nov 27, 2023
Try #1549:
0f9b389
@bors-openebs-mayastor
Copy link

try

Timed out.

@dsavitskiy dsavitskiy force-pushed the feature/io-engine-crash-fixes branch 2 times, most recently from 55ba1bb to c54fe99 Compare December 4, 2023 16:17
@dsavitskiy
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Dec 4, 2023
Try #1549:
b5a01d2
@bors-openebs-mayastor
Copy link

try

Build succeeded:

@dsavitskiy dsavitskiy force-pushed the feature/io-engine-crash-fixes branch from c54fe99 to 0b5374f Compare December 5, 2023 07:47
@dsavitskiy
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Dec 5, 2023
Try #1549:
03ff588
@bors-openebs-mayastor
Copy link

try

Build succeeded:

@dsavitskiy
feat(build): adding support for building and running with Address San…
e43ce7f 
…itizer

Added new "asan" argument for ci.nix shell that enables ASAN build:
* Nightly Rust is forced.
* Rust compiler flags are set to enable ASAN build.
* Cargo build shell variables are modified to support ASAN.
* Panic mode is set to "unwind".
* Docker config for tests is modifed to point to correct location of
  io-engine binary.
* LLVM symbolizer directory is added to PATH in docker config for tests.

Signed-off-by: Dmitry Savitskiy <dmitry.savitskiy@datacore.com>
@dsavitskiy
fix(asan): fixing issues found by address sanitizer
d0af2b8 
Signed-off-by: Dmitry Savitskiy <dmitry.savitskiy@datacore.com>
@dsavitskiy
fix(nexus): fixing I/O race when disconnecting retired device handles
bd8335d 
Signed-off-by: Dmitry Savitskiy <dmitry.savitskiy@datacore.com>
@dsavitskiy dsavitskiy force-pushed the feature/io-engine-crash-fixes branch from 0b5374f to bd8335d Compare December 5, 2023 16:29
@dsavitskiy
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 033dc9d into openebs:develop Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@datacore-vvarakantham datacore-vvarakantham datacore-vvarakantham left review comments

@dsharma-dc dsharma-dc dsharma-dc approved these changes

@hrudaya21 hrudaya21 Awaiting requested review from hrudaya21

@chriswldenyer chriswldenyer Awaiting requested review from chriswldenyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsavitskiy @tiagolobocastro @datacore-vvarakantham @dsharma-dc