Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use relative url for submodule #1544

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

chriswldenyer
Copy link
Contributor

Use a relative URL for importing the dependencies submodule.
The top-level part of the URL is the same between repos, so need not be duplicated,
and can be inferred from the URL of the parent repo.
Tested by building locally and via CI.

Signed-off-by: chriswldenyer <christopher.denyer@mayadata.io>
@chriswldenyer
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Nov 21, 2023
@bors-openebs-mayastor
Copy link

try

Build succeeded:

@chriswldenyer
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit e83ddf3 into develop Nov 22, 2023
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the relative-submodule-url branch November 22, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants