Skip to content

In means plot title, name the grouping #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

In means plot title, name the grouping #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acb0821
Include groups in means plot title
mccalluc May 8, 2025
5e6cf53
simplify by just using the "groups" variable that will be in context
mccalluc May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dp_wizard/utils/code_generators/analyses/histogram/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ def make_output(code_gen, column_name, accuracy_name, stats_name):
Template(f"histogram_{code_gen.root_template}_output", __file__)
.fill_values(
COLUMN_NAME=column_name,
GROUP_NAMES=code_gen.groups,
)
.fill_expressions(
ACCURACY_NAME=accuracy_name,
Expand Down
5 changes: 2 additions & 3 deletions dp_wizard/utils/code_generators/analyses/histogram/no-tests/_histogram_notebook_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
f"assuming {contributions} contributions per individual"
)

group_names = GROUP_NAMES
if group_names:
title += f" (grouped by {'/'.join(group_names)})"
if groups:
title += f" (grouped by {'/'.join(groups)})"
plot_bars(HISTOGRAM_NAME, error=ACCURACY_NAME, cutoff=0, title=title)
5 changes: 2 additions & 3 deletions dp_wizard/utils/code_generators/analyses/histogram/no-tests/_histogram_script_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@
f"assuming {contributions} contributions per individual"
)

group_names = GROUP_NAMES
if group_names:
print(f"(grouped by {'/'.join(group_names)})")
if groups:
print(f"(grouped by {'/'.join(groups)})")

print(CONFIDENCE_NOTE, ACCURACY_NAME)
print(HISTOGRAM_NAME)
12 changes: 7 additions & 5 deletions dp_wizard/utils/code_generators/analyses/mean/no-tests/_mean_notebook_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
title = (
f"DP means for COLUMN_NAME, "
f"assuming {contributions} contributions per individual"
)

if groups:
title = (
f"DP means for COLUMN_NAME, "
f"assuming {contributions} contributions per individual"
)
plot_bars(STATS_NAME, error=0, cutoff=0, title=title)
title += f" (grouped by {'/'.join(groups)})"
plot_bars(STATS_NAME, error=0, cutoff=0, title=title)
Loading