This repository was archived by the owner on Mar 17, 2023. It is now read-only.
forked from jupyter-on-openshift/poc-hub-openshift-auth
-
Notifications
You must be signed in to change notification settings - Fork 31
Update Python version of jupyterhub to Python 3.8 #115
Open
tmckayus
wants to merge
6
commits into
opendatahub-io-contrib:master
Choose a base branch
from
tmckayus:testpy38
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@vpavlin ptal Note, this needs a jupyterhub-quickstart base image that use Python 3.8 as well so we'll have a corresponding PR. |
Dependent on opendatahub-io-contrib/jupyterhub-quickstart#23 |
Test images at: quay.io/tmckayus/jupyterhub-quickstart:3.8 # built with updated dockerfile from opendatahub-io-contrib/jupyterhub-quickstart#23 |
In order for a build of jupyterhub to work using Python 3.8, we need a base image that also uses Python 3.8 which does not formally exist yet. Use a test image for CI.
/deploy |
2 similar comments
/deploy |
/deploy |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
…
This introduces a breaking change
This Pull Request implements
This PR changes the Python version to 3.8 in an image built from this repository
Description
Change the Python in the Pipfile and regenerate Pipfile.lock
Update a path in the .s2i/bin/assemble to reference Python 3.8 instead of 3.6
Change the import of distutils.util to work with Python 3.8