Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve brain hierarchy in article count / listing #18

Closed
wants to merge 8 commits into from

Conversation

BoBer78
Copy link
Collaborator

@BoBer78 BoBer78 commented Feb 26, 2025

closes #16

expanded_brain_regions = []
for region in regions:
expanded_brain_regions.extend(
get_descendants_names(region, "brainregion_hierarchy.json")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an env var in theory, but nexus will soon be removed and we track it on git so I guess it's fine.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we redefine the class and the processing for every brain region. We should maybe instantiate the class and read the json once, then call the resolving in the for loop.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be discussed, anyways, this will be closed

@BoBer78
Copy link
Collaborator Author

BoBer78 commented Mar 5, 2025

not needed anymore, we can re-open if there are some decision changes in 2 days.

@BoBer78 BoBer78 closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the hierarchy in article count / listing.
2 participants