-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve brain hierarchy in article count / listing #18
Conversation
expanded_brain_regions = [] | ||
for region in regions: | ||
expanded_brain_regions.extend( | ||
get_descendants_names(region, "brainregion_hierarchy.json") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be an env var in theory, but nexus will soon be removed and we track it on git so I guess it's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we redefine the class and the processing for every brain region. We should maybe instantiate the class and read the json once, then call the resolving in the for loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be discussed, anyways, this will be closed
not needed anymore, we can re-open if there are some decision changes in 2 days. |
closes #16