CellDistributor has many get cell methods

[cattabiani]

I find confusing that CellDistributor has these 3 methods:

• getCell is a wrapper of get_cellref
• get_cell
• get_cellref
• getMEType is a wrapper of get_cell

I think we can find more descriptive names or remove some of them

@WeinaJi about # Methods for compat with hoc suggests:

You may check if they are called by any hoc file, including the *helper.hoc

[cattabiani]

I just discovered that getCell is a wrapper of get_cellref. Clearly one can go except if they are not used for compatibility reasons...

[mgeplf]

I just discovered that get_cellref isn't called using the current ringtest...

[cattabiani]

which ringtest? test_ringcells.py? There are multiple tests that use that simulation_config.json

[WeinaJi]

get_cellref should the cell hoc object created by the emodel hoc template

neurodamus/neurodamus/metype.py

Line 169 in 8a7056d

self._cellref = EModel(gid, morpho_path, morpho_file, *add_params)

I just discovered that get_cellref isn't called using the current ringtest...

Probably because the reports are disabled. It is called in

neurodamus/neurodamus/target_manager.py

Line 472 in 8a7056d

cellObj = cell_manager.get_cellref(gid)

and other places in the same file regarding the sections/segments of cells.

[mgeplf]

which ringtest? test_ringcells.py?

Yeah: tox -eunit -- -sv tests/unit/test_ringcells.py

Probably because the reports are disabled.

Ah, can't wait for a unit test w/ reports then.