Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning in PixelObservationWrapper if render_mode is None #2978

Merged
merged 4 commits into from
Jul 18, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions gym/wrappers/pixel_observation.py
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
import numpy as np

import gym
from gym import spaces
from gym import logger, spaces

STATE_KEY = "state"

@@ -24,21 +24,21 @@ class PixelObservationWrapper(gym.ObservationWrapper):
Example:
>>> import gym
>>> env = PixelObservationWrapper(gym.make('CarRacing-v1'))
>>> env = PixelObservationWrapper(gym.make('CarRacing-v1', render_mode="single_rgb_array"))
>>> obs = env.reset()
>>> obs.keys()
odict_keys(['pixels'])
>>> obs['pixels'].shape
(400, 600, 3)
>>> env = PixelObservationWrapper(gym.make('CarRacing-v1'), pixels_only=False)
>>> env = PixelObservationWrapper(gym.make('CarRacing-v1', render_mode="single_rgb_array"), pixels_only=False)
>>> obs = env.reset()
>>> obs.keys()
odict_keys(['state', 'pixels'])
>>> obs['state'].shape
(96, 96, 3)
>>> obs['pixels'].shape
(400, 600, 3)
>>> env = PixelObservationWrapper(gym.make('CarRacing-v1'), pixel_keys=('obs',))
>>> env = PixelObservationWrapper(gym.make('CarRacing-v1', render_mode="single_rgb_array"), pixel_keys=('obs',))
>>> obs = env.reset()
>>> obs.keys()
odict_keys(['obs'])
@@ -92,8 +92,16 @@ def __init__(
f"Found key '{key}' in render_kwargs but not in pixel_keys."
)

default_render_kwargs = {}
if not env.render_mode:
default_render_kwargs = {"mode": "rgb_array"}
logger.warn(
"env.render_mode must be specified to use PixelObservationWrapper:"
"`gym.make(env_name, render_mode='single_rgb_array')`."
)

for key in pixel_keys:
render_kwargs.setdefault(key, {})
render_kwargs.setdefault(key, default_render_kwargs)

wrapped_observation_space = env.observation_space

@@ -130,6 +138,12 @@ def __init__(
pixels = self.env.render(**render_kwargs[pixel_key])
pixels: np.ndarray = pixels[-1] if isinstance(pixels, List) else pixels

if not hasattr(pixels, "dtype") or not hasattr(pixels, "shape"):
raise TypeError(
f"Render method returns a {pixels.__class__.__name__}, but an array with dtype and shape is expected."
"Be sure to specify the correct render_mode."
)

if np.issubdtype(pixels.dtype, np.integer):
low, high = (0, 255)
elif np.issubdtype(pixels.dtype, np.float):