Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Croatia not coloured green in overview map #389

Open
stefanb opened this issue May 26, 2024 · 4 comments
Open

Croatia not coloured green in overview map #389

stefanb opened this issue May 26, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@stefanb
Copy link

stefanb commented May 26, 2024

Describe the bug

Croatia is not marked as covered on the overview map, even though it was added in openaddresses/openaddresses#7172 and is being covered in https://batch.openaddresses.io/location/862

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://batch.openaddresses.io/data
  2. Scroll down to Individual Sources map
  3. See Croatia in white instead of green

Expected behavior
Croatia should be coloured green on the map

Screenshots
https://batch.openaddresses.io/data
image

https://batch.openaddresses.io/location/862
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
There was a similar problem with Kosovo openaddresses/machine#700 but that was a bit more politically problematic area.

@stefanb stefanb added the bug Something isn't working label May 26, 2024
@iandees
Copy link
Member

iandees commented May 27, 2024

I believe the tiles that make up the map with highlighted regions is heavily cached. It might be that those need to get flushed?

@stefanb
Copy link
Author

stefanb commented Jul 1, 2024

Cache seems to be very heavy indeed... 😄

@iandees
Copy link
Member

iandees commented Jul 9, 2024

Yes – I think it's an indefinite cache and I'm not sure how to clear it. @ingalls any ideas here?

@mnalis
Copy link

mnalis commented Dec 8, 2024

I've tried to debug from the client side... By doing partial blocking in firefox developer console, it seems that the stale data is coming from https://batch.openaddresses.io/api/map/0/0/0.mvt (and other closer zooms too).

Unfortunately the client-facing web server does not provide Last-Modified: header, so we don't know when it was updated, but it does say it is coming from Cloudflare CDN, which however claims (via CF-Cache-Status: DYNAMIC) that it did not consider data eligible for caching and has fetched it from origin web server.

Which in turn would seem to indicate that perhaps those global .mvt are not being updated?

HTTP header details
% wget -S https://batch.openaddresses.io/api/map/0/0/0.mvt
--2024-12-08 15:22:06--  https://batch.openaddresses.io/api/map/0/0/0.mvt
Resolving batch.openaddresses.io (batch.openaddresses.io)... 188.114.97.3, 188.114.96.3, 2a06:98c1:3121::3, ...
Connecting to batch.openaddresses.io (batch.openaddresses.io)|188.114.97.3|:443... connected.
HTTP request sent, awaiting response...
  HTTP/1.1 200 OK
  Date: Sun, 08 Dec 2024 14:22:06 GMT
  Content-Type: application/vnd.mapbox-vector-tile
  Transfer-Encoding: chunked
  Connection: keep-alive
  Vary: Origin
  Access-Control-Allow-Credentials: true
  cache-control: no-transform
  CF-Cache-Status: DYNAMIC
  Report-To: {"endpoints":[{"url":"https:\\/\\/a.nel.cloudflare.com\\/report\\/v4?s=Gis1VC1ZCTHjjB7q1WVDj9b%2Bk2NY6AkOKMiU0N26wC%2Fi4Fg0RAxavlUEE0%2BKHLjLBoxP1B445Tr1ZvDL0DI27U4yrvONniJQUU5Yuea8WK03fY%2FxFHyR8iWzVBpNHPyPgcrQCugw%2FBWA"}],"group":"cf-nel","max_age":604800}
  NEL: {"success_fraction":0,"report_to":"cf-nel","max_age":604800}
  Server: cloudflare
  CF-RAY: 8eed67dbf8d95b33-VIE
  alt-svc: h3=":443"; ma=86400
  server-timing: cfL4;desc="?proto=TCP&rtt=15797&min_rtt=14760&rtt_var=6276&sent=7&recv=7&lost=0&retrans=0&sent_bytes=3126&recv_bytes=773&delivery_rate=294308&cwnd=252&unsent_bytes=0&cid=d538afcf1fbddb5e&ts=325&x=0"
Length: unspecified [application/vnd.mapbox-vector-tile]

The fact it colors normally when specifying county directly (e.g. via https://batch.openaddresses.io/location/862) seems not related to the issue, as that seems to use MultiPolygon GeoJSON to color green the specified country (e.g. via https://batch.openaddresses.io/api/map/862) regardless if it has any data in openaddresses or not.


TL;DR: someone with access to the server would probably need to check why those .mvt files are seemingly not being regenerated automatically when new country sources are added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants