Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: consider calling disassembler in template tests #963

Open
zapateo opened this issue Dec 13, 2024 · 0 comments
Open

test: consider calling disassembler in template tests #963

zapateo opened this issue Dec 13, 2024 · 0 comments
Labels
disassembler Related to disassembler templates Related to the template Testing

Comments

@zapateo
Copy link
Member

zapateo commented Dec 13, 2024

If the disassembler were called to render the byte code of the compiled template code in the tests, one would be able to catch errors like the one reported in issue #962, which occur because the byte code is incorrect and the disassembler panics.

One option is then to call the disassembler for example in the TestMultiFileTemplate test (without necessarily checking the disassembler output, since that would require an even more extensive and broad test, which would be outside the scope of these tests).

Current limitation

This is currently not possible as it would result in disassembler panics due to issue #962.

@zapateo zapateo added disassembler Related to disassembler templates Related to the template Testing labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disassembler Related to disassembler templates Related to the template Testing
Projects
None yet
Development

No branches or pull requests

1 participant